Skip to content

add public handle to object code #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

ksimpson-work
Copy link
Contributor

Weirdly I am not able to tag Michael or add him as reviewer.

close #490

@ksimpson-work ksimpson-work requested a review from leofang March 6, 2025 00:28
Copy link
Contributor

copy-pr-bot bot commented Mar 6, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ksimpson-work
Copy link
Contributor Author

/ok to test

This comment has been minimized.

Copy link

@isVoid isVoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the quick response. An optimization tips, with this new fixture, you can actually simplify a few others by:

@pytest.fixture(scope="function")
def get_saxpy_object_code(init_cuda):
...

@pytest.fixture(scope="function")
def get_saxpy_kernel_ptx(get_saxpy_object_code):
    mod = get_saxpy_object_code
    return mod._module, mod

@pytest.fixture(scope="function")
def get_saxpy_kernel(get_saxpy_object_code):
    mod = get_saxpy_object_code
    return mod.get_kernel("saxpy<float>"), mod

@leofang leofang added enhancement Any code-related improvements P0 High priority - Must do! cuda.core Everything related to the cuda.core module labels Mar 6, 2025
@leofang leofang added this to the cuda.core beta 3 milestone Mar 6, 2025
@ksimpson-work ksimpson-work merged commit e76b1c5 into NVIDIA:main Mar 6, 2025
76 checks passed
Copy link

github-actions bot commented Mar 6, 2025

Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda.core Everything related to the cuda.core module enhancement Any code-related improvements P0 High priority - Must do!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide accessor for ObjectCode._handle
3 participants