Skip to content

Increase tolerance in test_timing() to avoid flaky tests. #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2025
Merged

Increase tolerance in test_timing() to avoid flaky tests. #498

merged 1 commit into from
Mar 7, 2025

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented Mar 7, 2025

Observed failures:

>           assert delay_seconds * 1000 <= elapsed_time_ms < delay_seconds * 1000 + 2  # tolerance 2 ms
E           assert 503.1598205566406 < ((0.5 * 1000) + 2)

>           assert delay_seconds * 1000 <= elapsed_time_ms < delay_seconds * 1000 + 2  # tolerance 2 ms
E           assert 505.0583190917969 < ((0.5 * 1000) + 2)

@rwgk
Increase tolerance in test_timing() to avoid flaky tests.
41d493e 
Observed failures:

```
>           assert delay_seconds * 1000 <= elapsed_time_ms < delay_seconds * 1000 + 2  # tolerance 2 ms
E           assert 503.1598205566406 < ((0.5 * 1000) + 2)
```

```
>           assert delay_seconds * 1000 <= elapsed_time_ms < delay_seconds * 1000 + 2  # tolerance 2 ms
E           assert 505.0583190917969 < ((0.5 * 1000) + 2)
```
@copy-pr-bot copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Mar 7, 2025

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@rwgk rwgk requested a review from leofang March 7, 2025 03:31
@rwgk
Copy link
Collaborator Author

rwgk commented Mar 7, 2025 •
edited
Loading

This passed testing under #497. Could you please admin-merge, so we don't waste testing resources?

leofang
leofang approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@leofang leofang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks Ralf!

@leofang leofang added P0 High priority - Must do! test Improvements or additions to tests cuda.core Everything related to the cuda.core module labels Mar 7, 2025
@leofang leofang added this to the cuda.core beta 3 milestone Mar 7, 2025
@leofang leofang merged commit 6897c26 into NVIDIA:main Mar 7, 2025
4 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025

Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leofang leofang leofang approved these changes

Assignees

@rwgk rwgk

Labels
cuda.core Everything related to the cuda.core module P0 High priority - Must do! test Improvements or additions to tests
Projects
None yet
Milestone
cuda.core beta 3
Development

Successfully merging this pull request may close these issues.
2 participants
@rwgk @leofang