-
Notifications
You must be signed in to change notification settings - Fork 171
PyTorch example #579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PyTorch example #579
Conversation
Signed-off-by: Mark Saroufim <[email protected]>
Many thanks to your contributions, @msaroufim! 🙏 Please give us a bit of time to unblock you -- This repository, including |
No worries @leofang I understand, great repo! So looking forward to contributing more soon! |
@leofang is this ready for a review? FWIW this is the PR I'm most interested in of the 3 I sent |
@msaroufim apologies for the delay in reviewing this. The examples are run as part of the test suite so I think we need to add pytorch to the test dependencies: the And then also modify the test utilities to properly skip if torch isn't installed in the environment:
|
Thanks @kkraus14 mind kicking off a test run for me please? |
/ok to test 1378e6a |
The testing runs on infrastructure that requires an NVIDIA maintainer to trigger. |
/ok to test 1378e6a |
Co-authored-by: Keith Kraus <[email protected]>
Co-authored-by: Keith Kraus <[email protected]>
This comment has been minimized.
This comment has been minimized.
/ok to test 01ad808 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition, thanks @msaroufim! I'll add another StridedMemoryView
based example later (after #150 is done) and it will also be able to handle PyTorch tensors too, without users fetching the pointer as kernel arg. Will ping you for review.
Co-authored-by: Keith Kraus <[email protected]>
Co-authored-by: Keith Kraus <[email protected]>
Co-authored-by: Leo Fang <[email protected]>
Co-authored-by: Leo Fang <[email protected]>
Co-authored-by: Leo Fang <[email protected]>
Regarding the testing changes @leofang please feel free to revert depending on what makes sense to you, I just tested your changes now locally and everything worked well |
/ok to test 7d3582f |
|
Description
This PR provides an end to end example of integrating PyTorch with cuda-python. In particular this PR
Limitation
Example of running this locally
Checklist