Skip to content

Add lint instructions #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 29, 2025
Merged

Add lint instructions #581

merged 5 commits into from
Apr 29, 2025

Conversation

msaroufim
Copy link
Contributor

@msaroufim msaroufim commented Apr 25, 2025 •
edited
Loading

Description

Add instructions on how to lint the repo for new contributors

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Apr 25, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@msaroufim msaroufim changed the title lint Add lint instructions Apr 25, 2025
@msaroufim
signoff
880fa9a 
Signed-off-by: Mark Saroufim <[email protected]>
@leofang leofang added documentation Improvements or additions to documentation support All things related to the project that can't be categorized P1 Medium priority - Should do blocked This task is currently blocked by other tasks labels Apr 26, 2025
@leofang leofang added this to the cuda.core beta 4 milestone Apr 26, 2025
@leofang leofang removed the blocked This task is currently blocked by other tasks label Apr 28, 2025
@leofang leofang requested review from rwgk and vzhurba01 April 29, 2025 01:19
rwgk
rwgk reviewed Apr 29, 2025
View reviewed changes
@vzhurba01 vzhurba01 mentioned this pull request Apr 29, 2025
Merged
2 tasks
@msaroufim msaroufim requested a review from rwgk April 29, 2025 18:09
@kkraus14
Copy link
Collaborator

Skipping CI as it's a markdown only change. Thanks @msaroufim!

@kkraus14 kkraus14 merged commit 9e868ba into NVIDIA:main Apr 29, 2025
1 check passed
@github-actions GitHub Actions
Copy link

Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkraus14 kkraus14 kkraus14 approved these changes

@vzhurba01 vzhurba01 Awaiting requested review from vzhurba01

@rwgk rwgk Awaiting requested review from rwgk

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation P1 Medium priority - Should do support All things related to the project that can't be categorized
Projects
None yet
Milestone
cuda.core beta 4
Development

Successfully merging this pull request may close these issues.
4 participants
@msaroufim @kkraus14 @rwgk @leofang