-
Notifications
You must be signed in to change notification settings - Fork 171
Ensure fetch_ctk
action can be used everywhere
#600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
e7627e3
test installing git for windows
leofang 562b558
shrink CI
leofang c54332b
also install 7z...
leofang 270b681
skip cuda.bindings for now
leofang 9e665db
fix
leofang 38830b2
fix
leofang 4a2bb6f
fix
leofang 2bb32a9
skip
leofang dc633dc
skip
leofang cd69de3
more skip
leofang 52adef2
add quotes
leofang d5c7be2
try this
leofang efd6036
try this
leofang 1c8d7a8
try this
leofang 4cb69d6
don't escape?
leofang 10de33c
try this
leofang 3cfc4e3
--version does not exist
leofang fffe85c
switch to fetch_ctk
leofang daf26ad
try not to hang
leofang 0a578be
try not to hang
leofang f3fa596
try not to hang; composite action does not support setting default sh…
leofang fa6abf0
Merge branch 'main' into fix_win
leofang 0418045
self extracting + run post install
leofang 869ff14
block extraction to ensure file visibility
leofang ffa239e
clean up
leofang 1b02e55
ensure cuda related paths are set correctly on windows
leofang 7a0e053
fix normpath (again) to escape slash
leofang 96ecae0
DEBUG
leofang a73564c
perhaps git-bash is not the right exe...
leofang 78d0113
install zstd for win local ctk test
leofang 390995a
fix copy pasta
leofang 65e19b2
forward-port fetch_ctk fix
leofang 6ade91b
ready for full test!
leofang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -57,14 +57,6 @@ jobs: | |
$SKIP_CUDA_BINDINGS_TEST = 0 | ||
} | ||
|
||
if ('${{ inputs.local-ctk }}' -eq '1') { | ||
if ($TEST_CUDA_MAJOR -eq '12') { | ||
$MINI_CTK_DEPS = '["nvcc", "nvrtc", "nvjitlink", "thrust"]' | ||
} else { | ||
$MINI_CTK_DEPS = '["nvcc", "nvrtc", "thrust"]' | ||
} | ||
} | ||
|
||
# Make outputs from the previous job as env vars | ||
$CUDA_CORE_ARTIFACT_BASENAME = "cuda-core-python${PYTHON_VERSION_FORMATTED}-${{ inputs.host-platform }}" | ||
"PYTHON_VERSION_FORMATTED=${PYTHON_VERSION_FORMATTED}" >> $env:GITHUB_ENV | ||
|
@@ -76,7 +68,6 @@ jobs: | |
"CUDA_BINDINGS_ARTIFACT_NAME=${CUDA_BINDINGS_ARTIFACT_BASENAME}-${{ github.sha }}" >> $env:GITHUB_ENV | ||
"CUDA_BINDINGS_ARTIFACTS_DIR=$($ExecutionContext.SessionState.Path.GetUnresolvedProviderPathFromPSPath("$REPO_DIR\cuda_bindings\dist"))" >> $env:GITHUB_ENV | ||
"SKIP_CUDA_BINDINGS_TEST=${SKIP_CUDA_BINDINGS_TEST}" >> $env:GITHUB_ENV | ||
"MINI_CTK_DEPS=${MINI_CTK_DEPS}" >> $env:GITHUB_ENV | ||
|
||
- name: Download cuda-python build artifacts | ||
if: ${{ env.SKIP_CUDA_BINDINGS_TEST == '0'}} | ||
|
@@ -107,6 +98,36 @@ jobs: | |
} | ||
gh --version | ||
|
||
- name: Install Git for Windows | ||
# the GPU runner image does not have Git Bash pre-installed... | ||
if: ${{ inputs.local-ctk == '1' }} | ||
env: | ||
# doesn't seem there's an easy way to avoid hard-coding it? | ||
GFW_EXE_URL: https://github.com/git-for-windows/git/releases/download/v2.49.0.windows.1/PortableGit-2.49.0-64-bit.7z.exe | ||
run: | | ||
Invoke-WebRequest -Uri "$env:GFW_EXE_URL" -OutFile "PortableGit.7z.exe" | ||
# Self-extracting, see https://gitforwindows.org/zip-archives-extracting-the-released-archives.html | ||
Start-Process .\PortableGit.7z.exe -Wait -Verbose -ArgumentList '-y -gm2' | ||
ls -l PortableGit | ||
echo "$((Get-Location).Path)\\PortableGit\\bin" >> $env:GITHUB_PATH | ||
$env:Path += ";$((Get-Location).Path)\\PortableGit\\bin" | ||
bash --version | ||
|
||
- name: Install zstd | ||
# the GPU runner image does not have zstd pre-installed... and it's needed by actions/cache | ||
if: ${{ inputs.local-ctk == '1' }} | ||
env: | ||
# doesn't seem there's an easy way to avoid hard-coding it? | ||
ZSTD_URL: https://github.com/facebook/zstd/releases/download/v1.5.7/zstd-v1.5.7-win64.zip | ||
ZSTD_DIR: zstd-v1.5.7-win64 | ||
run: | | ||
Invoke-WebRequest -Uri "$env:ZSTD_URL" -OutFile "zstd-win64.zip" | ||
Expand-Archive -Path "zstd-win64.zip" -DestinationPath . | ||
ls -l $env:ZSTD_DIR | ||
echo "$((Get-Location).Path)\\$env:ZSTD_DIR" >> $env:GITHUB_PATH | ||
$env:Path += ";$((Get-Location).Path)\\$env:ZSTD_DIR" | ||
zstd --version | ||
|
||
- name: Download cuda-python & cuda.bindings build artifacts from the prior branch | ||
if: ${{ env.SKIP_CUDA_BINDINGS_TEST == '1'}} | ||
env: | ||
|
@@ -160,20 +181,11 @@ jobs: | |
|
||
- name: Set up mini CTK | ||
if: ${{ inputs.local-ctk == '1' }} | ||
# Note: The GH-hosted Windows GPU runner does not have Git for Windows pre-installed, | ||
# so we cannot use our own fetch_ctk action unfortunately... | ||
uses: Jimver/[email protected] | ||
uses: ./.github/actions/fetch_ctk | ||
continue-on-error: false | ||
with: | ||
cuda: ${{ inputs.cuda-version }} | ||
method: 'network' | ||
sub-packages: ${{ env.MINI_CTK_DEPS }} | ||
|
||
- name: Update PATH | ||
if: ${{ inputs.local-ctk == '1' }} | ||
run: | | ||
# mimics actual CTK installation | ||
echo $PATH | ||
echo "$env:CUDA_PATH\nvvm\bin" >> $env:GITHUB_PATH | ||
host-platform: ${{ inputs.host-platform }} | ||
cuda-version: ${{ inputs.cuda-version }} | ||
|
||
- name: Run cuda.bindings tests | ||
if: ${{ env.SKIP_CUDA_BINDINGS_TEST == '0' }} | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.