Bugfix/multiple ptxas options values #678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksandr-pavlyk
added
bug
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
The correct way to handle multiple options is to pass them to NVRTC one at a time, e.g., ``` --ptxas-options=val1 --ptxas-options=val2 ```
oleksandr-pavlyk
force-pushed
the
bugfix/multiple-ptxas-options-values
branch
from
2d004bc to
b06a6a5
Compare
|
/ok to test |
leofang
approved these changes
Jun 4, 2025
This comment has been minimized.
This comment has been minimized.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes gh-668
This PR fixes the issue by changing how sequence values for
ptxas_optionsare handled. Multiple values should be passed to NVRTC as a sequence of--ptx-options=valfor eachvalin the sequence.Checklist