Skip to content

Allow ObjectCode to have a name #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 6, 2025
Merged

Allow ObjectCode to have a name #682

merged 5 commits into from
Jun 6, 2025

Conversation

leofang
Copy link
Member

@leofang leofang commented Jun 5, 2025

Description

Close #506. Close #662.

ObjectCode can be named in all cases:

  • if generated by Program.compile(), passed through the program option
  • if generated by Linker.link(), passed through the linker option
  • if created via alternative constructors, passed through the constructor argument

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@leofang leofang added this to the cuda.core beta 4 milestone Jun 5, 2025
@leofang leofang added P1 Medium priority - Should do feature New feature or request cuda.core Everything related to the cuda.core module labels Jun 5, 2025
@github-project-automation github-project-automation bot moved this to Todo in CCCL Jun 5, 2025
@copy-pr-bot copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Jun 5, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang
Copy link
Member Author

leofang commented Jun 5, 2025

@brandon-b-miller could you check if this meets Numba-cuda's needs?

@leofang leofang self-assigned this Jun 5, 2025
@leofang
Copy link
Member Author

leofang commented Jun 5, 2025

/ok to test f72b1c0

@leofang leofang mentioned this pull request Jun 5, 2025
Open
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@brandon-b-miller
Copy link
Contributor

Hi @leofang , with this branch and NVIDIA/numba-cuda@4fad9f3 the last failing test is now a pass for me locally.

kkraus14
kkraus14 previously approved these changes Jun 6, 2025
View reviewed changes
@github-project-automation github-project-automation bot moved this from Todo to In Review in CCCL Jun 6, 2025
@leofang
Copy link
Member Author

leofang commented Jun 6, 2025

/ok to test be63566

@leofang
Copy link
Member Author

leofang commented Jun 6, 2025

/ok to test c8572b2

kkraus14
kkraus14 previously approved these changes Jun 6, 2025
View reviewed changes
@leofang
Copy link
Member Author

leofang commented Jun 6, 2025

Looks like we have a race here 😛 Since the CI was green and Keith approved, and I only merged the main branch to resolve a conflict in the release note, let me admin-merge.

@leofang leofang merged commit 9ef1562 into NVIDIA:main Jun 6, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from In Review to Done in CCCL Jun 6, 2025
@leofang leofang deleted the names branch June 6, 2025 13:43
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2025

Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkraus14 kkraus14 kkraus14 left review comments

Assignees

@leofang leofang

Labels
cuda.core Everything related to the cuda.core module feature New feature or request P1 Medium priority - Should do
Projects
CCCL
Status: Done
Milestone
cuda.core beta 4
Development

Successfully merging this pull request may close these issues.

[FEA]: Allow specifying the names of inputs to the Linker Support custom naming of nvrtc programs
3 participants
@leofang @brandon-b-miller @kkraus14