add --no-sort option #378
Merged
add --no-sort option #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as draft
ghost
marked this pull request as ready for review
This PR adds a command line option `--no-sort` which causes patchelf to refrain from sorting the program headers and section headers. A comment in the preexisting source code says that this was done only "for neatness". The `--no-sort` option, combined with `readelf -a` and `colordiff` is very useful for debugging patchelf problems. Without `--no-sort` the diffs are not usable -- everything changes because of the sorting.
Mic92
reviewed
Jun 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a command line option
--no-sortwhich causes patchelfto refrain from sorting the program headers and section headers. A
comment in the preexisting source code says that this was done only
"for neatness".
The
--no-sortoption, combined withreadelf -aandcolordiffisvery useful for debugging patchelf problems. Without
--no-sortthediffs are not usable -- everything changes because of the sorting.