feat: refactor part of bash script to be included in TF #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commjoen
reviewed
Feb 10, 2023
commjoen
reviewed
Feb 10, 2023
commjoen
reviewed
Feb 10, 2023
bendehaan
force-pushed
the
feat/tf-refactor
branch
from
50f96d6 to
19e449e
Compare
commjoen
approved these changes
Feb 10, 2023
There was a problem hiding this comment.
Thank you @bendehaan , this makes it all a lot cleaner and less hacky based on cloudformation stacks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #84