Skip to content

Fix for minikube tests #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 14, 2023
Merged

Fix for minikube tests #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0232fc9
Fix for minikube tests
commjoen Feb 14, 2023
684e28e
add debug line
commjoen Feb 14, 2023
d4c25d5
Update minikube-k8s-test.yml
commjoen Feb 14, 2023
8c71e1d
Merge branch 'main' into fix-k8s-test
commjoen Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/minikube-k8s-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,14 @@ jobs:
- name: Start minikube
uses: medyagh/setup-minikube@master
with:
minikube-version: 1.27.0
minikube-version: 1.29.0
driver: docker
kubernetes-version: v1.23.12
- name: test script
run: |
eval $(minikube docker-env)
./build-an-deploy.sh
while [[ $(kubectl get pods -l app=wrongsecrets-balancer -o 'jsonpath={..status.conditions[?(@.type=="Ready")].status}') != "True" ]]; do echo "waiting for wrongsecrets-balancer" && sleep 2; done
while [[ $(kubectl get pods -l app=wrongsecrets-balancer -o 'jsonpath={..status.conditions[?(@.type=="Ready")].status}') != *"True"* ]]; do echo "waiting for wrongsecrets-balancer" && sleep 2; done
kubectl logs deployments/wrongsecrets-balancer -f >> pod.log &
echo "port forwarding"
kubectl port-forward service/wrongsecrets-balancer 3000:3000 &
Expand Down
2 changes: 1 addition & 1 deletion helm/wrongsecrets-ctf-party/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ balancer:
cookieParserSecret: null
repository: jeroenwillemsen/wrongsecrets-balancer
tag: 1.7aws
# -- Number of replicas of the wrongsecrets-balancer deployment
# -- Number of replicas of the wrongsecrets-balancer deployment. Changing this in a commit? PLEASE UPDATE THE GITHUB WORKLFOWS THEN!(NUMBER OF "TRUE")
replicas: 4
service:
# -- Kubernetes service type
Expand Down
4 changes: 2 additions & 2 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ For minikube, run:

```shell

minikube start --cpus=6 --memory=10000MB --network-plugin=cni --cni=calico
minikube start --cpus=6 --memory=10000MB --network-plugin=cni --cni=calico --driver=docker
eval $(minikube docker-env)
./build-an-deploy-container.sh
kubectl port-forward service/wrongsecrets-balancer 3000:3000
Expand All @@ -129,7 +129,7 @@ kubectl top pods

```shell

minikube start --cpus=6 --memory=10000MB --network-plugin=cni --cni=calico
minikube start --cpus=6 --memory=10000MB --network-plugin=cni --cni=calico --driver=docker
eval $(minikube docker-env)
./build-an-deploy.sh
kubectl port-forward service/wrongsecrets-balancer 3000:3000
Expand Down