Skip to content

Check teamname before proxy & make hmackey configurable per deployment #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 3, 2022

Conversation

commjoen
Copy link
Collaborator

@commjoen commjoen commented Oct 3, 2022

No description provided.

@commjoen commjoen changed the title Check teamname for regex before continuing Check teamname before proxy & make hmackey configurable per deployment Oct 3, 2022
@@ -7,10 +7,10 @@
const expressJoiValidation = require('express-joi-validation');
const promClient = require('prom-client');
const accessPassword = process.env.REACT_APP_ACCESS_PASSWORD;
const hmac_key = process.env.REACT_APP_CREATE_TEAM_HMAC_KEY || 'hardcodedkey';

Check failure

Code scanning / CodeQL

Hard-coded credentials

The hard-coded value "hardcodedkey" is used as [key](1).
@commjoen commjoen merged commit 79994aa into main Oct 3, 2022
@commjoen commjoen deleted the fix-vulns branch October 3, 2022 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant