Feature app defined setLanguage

[tanaynigam]

Description

Line Summary

Add feature app-defined language implementation to OneSignal-Flutter-SDK. A user can define their own language setting to be used by OneSignal-SDK

Details

• Add setLanguage method to OneSignal Android plugin
• Add setLanguage method to OneSignal iOS plugin
• Update Podfile and onesignal_flutter.podspec files with OneSignalXCFramework 3.6.0
• Add setLanguage bridge methods to onesignal_flutter.dart

Test

• Test device using button click to call _handleSetLanguage to set it to language different from language defined by the app. OneSignal app dashboard reflects the language set using OneSignal.setLanguage
• Add unit test defining 'fr' using setLanguage callback that expects language returned to be the same

---

This change is 

[emawby]

Nit the commit that changes the iOS plugin is named add setLanguage to Android plugin.

Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @Jeasmine, @jkasten2, and @tanaynigam)

---

test/mock_channel.dart, line 71 at r1 (raw file):

        return {"success" : true};
      case "OneSignal#setLanguage":
      this.state.language = (call.arguments as Map<dynamic, dynamic>)['language'] as String?;;

nit indentation here looks off

[Jeasmine]

Could you add a space after the if? Also, isn't there a string utils notNullorEmpty? I might be wrong

[tanaynigam]

I think this condition i referred from setExternalUserId looks for a condition where the string may be non-null but is empty. I which case it assigns null value to the string (possibly to push null to the endpoint instead of an empty string?)

[Jeasmine]

in iOS i think you always need to put the braces {}

[jkasten2]

Reviewed 6 of 7 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @emawby and @tanaynigam)

---

test/mock_channel.dart, line 71 at r1 (raw file):

Previously, emawby (Elliot Mawby) wrote…

nit indentation here looks off

Remove extra semicolon ;

[jkasten2]

Reviewed 3 of 3 files at r3.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Jeasmine and @tanaynigam)

---

android/src/main/java/com/onesignal/flutter/OneSignalPlugin.java, line 344 at r2 (raw file):

Previously, tanaynigam (Tanay Nigam) wrote…

I think this condition i referred from setExternalUserId looks for a condition where the string may be non-null but is empty. I which case it assigns null value to the string (possibly to push null to the endpoint instead of an empty string?)

I think either way this is fine, since on REST API it will just set language to "en" for either "" or null values. Would code would be a simpler if we just remove this if completely. @Jeasmine thoughts on this?

[emawby]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Jeasmine and @tanaynigam)