Fix CI issue #524
Merged
Fix CI issue #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The doc that explains why this change needed to be made can be found in https://docs.flutter.dev/release/breaking-changes/mock-platform-channels#migration-guide
jkasten2
approved these changes
Jan 12, 2022
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @iAmWillShepherd)
|
Apologies, but I don't know the process for merging reviewed PRs. Who's responsibility is it to hit the button? I'm happy to do it, but don't want to do stuff out outside the process. |
|
@iAmWillShepherd Sorry missed this, the author can merge after a maintainer approves the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the last commit ba9eca1 resulted in a broken build; this is because
MethodChannel.setMockMethodCallHandlerwas replaced byTestDefaultBinaryMessenger.setMockMethodCallHandler(ref). The migration guide indicated that a specific package needed to be imported so the test could behave as expected.This change is