Skip to content

Android 13 push prompting #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 25, 2022
Merged

Android 13 push prompting #578

merged 5 commits into from
Jul 25, 2022

Conversation

emawby
Copy link
Contributor

@emawby emawby commented Jul 22, 2022

Description

One Line Summary

This PR implements push prompting in Android for Android 13 devices.

Details

There is no public API change for this, instead the existing push prompting API will now work on Android for Android devices 13+. In order to not immediately be prompted in Android 13 apps will need to set their Android target SDK version to 33+.

Motivation

New Android 13 feature

Scope

Push prompting

Testing

I tested on both iOS and Android devices for both accepting and denying permissions.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@emawby emawby force-pushed the android_push_prompt branch from 00f311f to 77c4dba Compare July 22, 2022 20:16
@emawby emawby requested review from nan-li and jkasten2 July 22, 2022 20:16
Copy link
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nan-li)

@emawby emawby merged commit ad5739c into main Jul 25, 2022
@emawby emawby deleted the android_push_prompt branch July 25, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants