Skip to content

Add Live Activities support #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 29, 2022
Merged

Add Live Activities support #621

merged 3 commits into from
Nov 29, 2022

Conversation

nan-li
Copy link
Contributor

@nan-li nan-li commented Nov 29, 2022

Description

One Line Summary

Adds Live Activity support.

Details

Motivation

Adding 2 SDK methods that allow a customer to register their temporary live activity token with an activity ID on OneSignal's backend:

  1. enterLiveActivity
  2. exitLiveActivity

Scope

Adding bridging to access the two iOS SDK methods.

Testing

Unit testing

The iOS repo contains tests, this is only bridging

Manual testing

Testing limited since no real push token is available.

  • Tested that the Flutter example app can call these two methods and receive the onFailure response with a correct 404 error.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

@nan-li nan-li force-pushed the feat/ios_live_activity_support branch from 09d69db to 3891a70 Compare November 29, 2022 18:13
Copy link
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nan-li)

@fhboswell fhboswell self-requested a review November 29, 2022 18:51
Copy link
Contributor

@fhboswell fhboswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nan-li)

@nan-li nan-li merged commit b536ae0 into main Nov 29, 2022
@nan-li nan-li deleted the feat/ios_live_activity_support branch November 29, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants