Skip to content

[User Model ]remove shared from OneSignal and make methods static #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2023

Conversation

emawby
Copy link
Contributor

@emawby emawby commented May 9, 2023

Description

One Line Summary

Everything on the shared instance of OneSignal should now be called on the static OneSignal namespace.

Details

Motivation

clean api

Testing

Manual testing

tested on iOS and android simulators

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@emawby emawby force-pushed the user_model/rename_events branch from 71e5b7b to c602bd5 Compare May 9, 2023 22:05
everything on the shared instance of OneSignal should now be called on the static OneSignal namespace.
@emawby emawby force-pushed the user_model/rename_events branch from c602bd5 to 95e72b9 Compare May 9, 2023 22:08
@emawby emawby merged commit 5bf8954 into user_model/main May 9, 2023
@emawby emawby deleted the user_model/rename_events branch May 9, 2023 22:34
@emawby emawby mentioned this pull request May 9, 2023
nan-li pushed a commit that referenced this pull request Jan 31, 2024
[User Model ]remove shared from OneSignal and make methods static
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants