Fix permission not updating until start of session #735
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
OneSignal.Notification.permission
value is now updated immediately when the permission value changes.Details
Fixes #734
The permission field was not marked as async so we cannot use
await _channel.invokeMethod("OneSignal#permission");
Instead I have added ourselves as a permission observer that will update the _permission boolean whenever the observer fires.
Motivation
bug fix
Scope
notification permissions
Testing
Manual testing
Tested on iOS device
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is