Skip to content

Fix permission not updating until start of session #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

emawby
Copy link
Contributor

@emawby emawby commented Sep 12, 2023

Description

One Line Summary

OneSignal.Notification.permission value is now updated immediately when the permission value changes.

Details

Fixes #734

The permission field was not marked as async so we cannot use await _channel.invokeMethod("OneSignal#permission");
Instead I have added ourselves as a permission observer that will update the _permission boolean whenever the observer fires.

Motivation

bug fix

Scope

notification permissions

Testing

Manual testing

Tested on iOS device

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@emawby emawby merged commit 6249244 into user_model/main Sep 14, 2023
@emawby emawby deleted the fix/permission_not_updating branch September 14, 2023 17:21
nan-li pushed a commit that referenced this pull request Jan 31, 2024
Fix permission not updating until start of session
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: OneSignal.Notifications.permission is not updated until next session [iOS]
2 participants