Skip to content

Update migration steps for iOS and clarify optIn #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 28, 2023

Conversation

emawby
Copy link
Contributor

@emawby emawby commented Sep 15, 2023

Description

One Line Summary

Update the migrations steps for iOS

Details

Update the comment for optedIn to fix #720

Also updates migration guide for the iOS import and cocoapods changes #726

Motivation

improve documentation

Scope

comments and migration guide

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@emawby emawby force-pushed the update_migration_steps branch from 89fc4a0 to 8fb0b23 Compare September 15, 2023 21:51
@nan-li nan-li mentioned this pull request Sep 25, 2023
8 tasks
* Primarily fix the format of tables so they display properly in markdown.
* In addition, there are some small tweaks that are made.
* Add `permissionNative()` to migration guide
* Add `Location.setShared(bool)` to migration guide
@nan-li nan-li merged commit 97a8048 into user_model/main Sep 28, 2023
@nan-li nan-li deleted the update_migration_steps branch September 28, 2023 00:08
@nan-li nan-li mentioned this pull request Sep 28, 2023
nan-li added a commit that referenced this pull request Jan 31, 2024
Update migration steps for iOS and clarify optIn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants