Skip to content

Fix notification clicked listener firing from cold start #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 27, 2023

Conversation

emawby
Copy link
Contributor

@emawby emawby commented Sep 26, 2023

Description

One Line Summary

This PR allows the click listener to be fired when the app is closed.

Details

  • Bumps the iOS dependency to 5.0.2
  • Don't register the bridge click listener until a dart click listener is added.
  • Initialize OneSignal native when the plugin is registered

Testing

Unit testing

none

Manual testing

Tested on Android and iOS devices with multiple push notifications from a cold start, background, and foreground.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@emawby emawby force-pushed the fix/notif_opened_when_closed branch from 4d22b01 to 462dc0d Compare September 26, 2023 23:14
@emawby emawby force-pushed the fix/notif_opened_when_closed branch from 462dc0d to e7fc68c Compare September 26, 2023 23:15
@emawby emawby merged commit e1a989a into user_model/main Sep 27, 2023
@emawby emawby deleted the fix/notif_opened_when_closed branch September 27, 2023 16:26
@nan-li nan-li mentioned this pull request Sep 28, 2023
nan-li pushed a commit that referenced this pull request Jan 31, 2024
Fix notification clicked listener firing from cold start
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants