Skip to content

[user model] Added the namespace property in build.gradle #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

nan-li
Copy link
Contributor

@nan-li nan-li commented Jan 25, 2024

Description

One Line Summary

This PR provide the package namespace if the AGP is equal or higher then 8.

Details

This PR is a cherry-pick of this main branch PR #765 for the user_model branch.

Motivation

By adding the namespace condition for AGP 8 and higher, this fix the issue [Bug]: AGP 8 not supported #764

Testing

Manual testing

Tested during the Gradle sync with AGP 9

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

@nan-li nan-li requested a review from emawby January 25, 2024 22:28
@nan-li nan-li changed the title User model/feature/agp 8 [user model] Added the namespace property in build.gradle Jan 25, 2024
@nan-li nan-li merged commit 28ad7d4 into user_model/main Jan 26, 2024
@nan-li nan-li deleted the user_model/feature/agp-8 branch January 26, 2024 18:21
@nan-li nan-li mentioned this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants