Skip to content

Bump com.networknt:json-schema-validator from 1.4.0 to 1.4.2 #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import com.fasterxml.jackson.databind.JsonNode
import com.fasterxml.jackson.databind.ObjectMapper
import com.networknt.schema.JsonSchemaFactory
import com.networknt.schema.OutputFormat
import com.networknt.schema.PathType
import com.networknt.schema.SchemaValidatorsConfig
import com.networknt.schema.SpecVersion.VersionFlag.V7
import com.networknt.schema.output.OutputFlag
Expand Down Expand Up @@ -65,7 +66,15 @@ abstract class AbstractComparisonBenchmark {
val factory = JsonSchemaFactory.getInstance(V7)
networkntSchema =
Path.of(schemaPath).inputStream().use {
factory.getSchema(it, SchemaValidatorsConfig())
factory.getSchema(
it,
SchemaValidatorsConfig
.builder()
.pathType(PathType.JSON_POINTER)
.errorMessageKeyword("message")
.nullableKeywordEnabled(false)
.build(),
)
}
networkntDocument =
Path.of(objectPath).inputStream().use {
Expand All @@ -77,7 +86,8 @@ abstract class AbstractComparisonBenchmark {
private fun setupKmp() {
schema =
Path.of(schemaPath).inputStream().use {
io.github.optimumcode.json.schema.JsonSchema.fromStream(it)
io.github.optimumcode.json.schema.JsonSchema
.fromStream(it)
}
document =
Path.of(objectPath).inputStream().use {
Expand All @@ -94,34 +104,30 @@ abstract class AbstractComparisonBenchmark {
openapiSchema = store.getSchema(uri)
openapiDocument =
JsonInstance(
converter.convert(Path.of(objectPath).inputStream().use { it.readAllBytes() }.toString(Charsets.UTF_8)),
converter.convert(
Path
.of(objectPath)
.inputStream()
.use { it.readAllBytes() }
.toString(Charsets.UTF_8),
),
)
}

@Benchmark
fun validateOpenApi(): ValidationStep {
return openapiValidator.validate(openapiSchema, openapiDocument)
}
fun validateOpenApi(): ValidationStep = openapiValidator.validate(openapiSchema, openapiDocument)

@Benchmark
fun validateNetworkntFlag(): OutputFlag? {
return networkntSchema.validate(networkntDocument, OutputFormat.FLAG)
}
fun validateNetworkntFlag(): OutputFlag? = networkntSchema.validate(networkntDocument, OutputFormat.FLAG)

@Benchmark
fun validateNetworkntDetailed(): OutputUnit {
return networkntSchema.validate(networkntDocument, OutputFormat.LIST)
}
fun validateNetworkntDetailed(): OutputUnit = networkntSchema.validate(networkntDocument, OutputFormat.LIST)

@Benchmark
fun validateNetworkntVerbose(): OutputUnit {
return networkntSchema.validate(networkntDocument, OutputFormat.HIERARCHICAL)
}
fun validateNetworkntVerbose(): OutputUnit = networkntSchema.validate(networkntDocument, OutputFormat.HIERARCHICAL)

@Benchmark
fun validateKmpEmptyCollector(): Boolean {
return schema.validate(document, ErrorCollector.EMPTY)
}
fun validateKmpEmptyCollector(): Boolean = schema.validate(document, ErrorCollector.EMPTY)

@Benchmark
fun validateKmpCollectErrors(): List<ValidationError> {
Expand All @@ -131,17 +137,11 @@ abstract class AbstractComparisonBenchmark {
}

@Benchmark
fun validateKmpFlag(): ValidationOutput.Flag {
return schema.validate(document, OutputCollector.flag())
}
fun validateKmpFlag(): ValidationOutput.Flag = schema.validate(document, OutputCollector.flag())

@Benchmark
fun validateKmpDetailed(): ValidationOutput.OutputUnit {
return schema.validate(document, OutputCollector.detailed())
}
fun validateKmpDetailed(): ValidationOutput.OutputUnit = schema.validate(document, OutputCollector.detailed())

@Benchmark
fun validateKmpVerbose(): ValidationOutput.OutputUnit {
return schema.validate(document, OutputCollector.verbose())
}
fun validateKmpVerbose(): ValidationOutput.OutputUnit = schema.validate(document, OutputCollector.verbose())
}
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ openapi-jackson = { module = "io.openapiprocessor:io-jackson" }
jackson-bom = { group = "com.fasterxml.jackson", name = "jackson-bom", version.ref = "jackson" }
jackson-databind = { module = "com.fasterxml.jackson.core:jackson-databind" }
jackson-yaml = { module = "com.fasterxml.jackson.dataformat:jackson-dataformat-yaml" }
networknt-validator = { group = "com.networknt", name = "json-schema-validator", version = "1.4.0" }
networknt-validator = { group = "com.networknt", name = "json-schema-validator", version = "1.4.2" }
kotlinpoet = { group = "com.squareup", name = "kotlinpoet", version = "1.17.0" }
graphql-ktor = { group = "com.expediagroup", name = "graphql-kotlin-ktor-client", version.ref = "graphql" }
clikt = { group = "com.github.ajalt.clikt", name = "clikt", version = "4.4.0" }
Expand Down
Loading