Skip to content

Rework the way the circled references are determine to avoid false-positive results #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 12, 2024

Conversation

OptimumCode
Copy link
Owner

Resolves #49

@OptimumCode OptimumCode added the fix Fix for bug label Feb 12, 2024
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (e867a0c) 90.16% compared to head (19bf89b) 90.03%.

Files Patch % Lines
...ub/optimumcode/json/pointer/internal/extensions.kt 33.33% 1 Missing and 3 partials ⚠️
...mumcode/json/schema/internal/ReferenceValidator.kt 86.95% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
- Coverage   90.16%   90.03%   -0.13%     
==========================================
  Files          90       90              
  Lines        2033     2058      +25     
  Branches      499      509      +10     
==========================================
+ Hits         1833     1853      +20     
- Misses         41       42       +1     
- Partials      159      163       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OptimumCode OptimumCode merged commit 90a49ea into main Feb 12, 2024
@OptimumCode OptimumCode deleted the issue_#49 branch February 12, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix for bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct circled references detection logic
1 participant