Fix beforeLoad not being called in some requests #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix beforeLoad not being called in some requests - initially reported in apache#686
The waitForBeforeload flag was preventing beforeLoad from being called on every GET request.
Platforms affected
Motivation and Context
When using the beforeLoad event, we have noticed that it wasn't triggered in every navigation. The reason was related to the waitForBeforeload flag, which was intermittently set to true and bypassing the beforeLoad event.
This flag doesn't seem to be required, and there's no documentation of why it has been introduced. Some analysis of it has already been done in apache#755
Fixes apache#686
Description
Removed the waitForBeforeload flag from the code.
Testing
Tested with MABS 7.2.
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)