Skip to content

Fix beforeLoad not being called in some requests #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

leonardo-fernandes
Copy link

Fix beforeLoad not being called in some requests - initially reported in apache#686

The waitForBeforeload flag was preventing beforeLoad from being called on every GET request.

Platforms affected

  • Android
  • iOS

Motivation and Context

When using the beforeLoad event, we have noticed that it wasn't triggered in every navigation. The reason was related to the waitForBeforeload flag, which was intermittently set to true and bypassing the beforeLoad event.
This flag doesn't seem to be required, and there's no documentation of why it has been introduced. Some analysis of it has already been done in apache#755

Fixes apache#686

Description

Removed the waitForBeforeload flag from the code.

Testing

Tested with MABS 7.2.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@nflsilva nflsilva changed the base branch from outsystems to fix/RMET-1290/prs-external-fixes January 14, 2022 08:40
@nflsilva nflsilva merged commit f36852c into OutSystems:fix/RMET-1290/prs-external-fixes Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants