Tests should pass in CBF mode #1076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests had sneaked in which would pass in CS mode, but not in CBF mode - at least, not without some tweaks. CBF specific tests were already being run in CBF mode and run against every supported PHP version. This commit now adds a test run of the complete test suite in CBF mode against one (high) PHP version to ensure that (new) tests always take both modes into account and no new issues like this can sneak in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SniffsExcludeArgsTest: allow for the test to pass in CBF mode
GeneratorArgTest: skip tests when in CBF mode
DisplayCachedMessagesTest: allow for the tests to pass in CBF mode
GH Actions/tests: safeguard that tests pass in CBF mode
Some tests had sneaked in which would pass in CS mode, but not in CBF mode - at least, not without some tweaks.
CBF specific tests were already being run in CBF mode and run against every supported PHP version.
This commit now adds a test run of the complete test suite in CBF mode against one (high) PHP version to ensure that (new) tests always take both modes into account and no new issues like this can sneak in.
Suggested changelog entry
N/A