Skip to content

docs: Correct semi-colon for semicolon (without dash) #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2024
Merged

docs: Correct semi-colon for semicolon (without dash) #464

merged 2 commits into from
Apr 29, 2024

Conversation

DannyvdSluijs
Copy link
Contributor

Semicolon is the correct spelling based on the Oxford Dictionary and dictionary.com. This PR changes all occurrences found into semicolon

Description

This PR is a split on changes proposed earlier in #457 but limiting to only fixing typos of the word semicolon.
Sources for the correct spelling are:

Also Google trends show a difference between semicolon and semi-colon

Suggested changelog entry

Correct semi-colon with semicolon

Related issues/external references

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement

PR checklist

  • I have checked there is no other PR open for the same change.
  • I have read the Contribution Guidelines.
  • I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
  • I have added tests to cover my changes.
  • I have verified that the code complies with the projects coding standards.
  • [Required for new sniffs] I have added XML documentation for the sniff.

Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DannyvdSluijs Thank you for doing this!

Looking good. I just have two small remarks for you to look at, but other than that, good to go.

Semicolon is the correct spelling based on the Oxford Dictionary and dictionary.com
Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DannyvdSluijs for working on this. All good now.

@jrfnl jrfnl merged commit 7aceb91 into PHPCSStandards:master Apr 29, 2024
jrfnl pushed a commit that referenced this pull request Apr 29, 2024
Semicolon is the correct spelling based on the Oxford Dictionary and dictionary.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants