call static instead of self on protected method #1611
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
No linked issue.
When you want to extends PhpOffice\PhpWord\Shared\Html class, the protected method parseNode, will call "self::parseChildNodes" making the call parseNode useless in the new class. And prevent parseChildNodes from being customized in the new class.
The change made allows the parseNode method to look for parseChildNodes first in the newly created class
More concretely, you can now customize parseChildNodes by extending the Html class
Maybe we can do same thing with all static methods (replacing calls self:: by static::)
Checklist:
composer run-script check --timeout=0
and no errors were reported