Skip to content

Use relative links in README to ensure they go to the correct branch #1658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2019

Conversation

0b10011
Copy link
Contributor

@0b10011 0b10011 commented Jul 11, 2019

Description

I went in to check the updated CONTRIBUTING file and noticed the link in the README directs users to CONTRIBUTING.md on the master branch. I've updated that link and one other to use relative links so they'll always link to the current branch (and will be more portable).

Fixes # (issue)

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.63% when pulling 5f8fad3 on 0b10011:readmelinks into 06c2f56 on PHPOffice:develop.

@troosan troosan merged commit fa6a80f into PHPOffice:develop Jul 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants