Skip to content

Added return type #1712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2019
Merged

Added return type #1712

merged 1 commit into from
Sep 30, 2019

Conversation

fmasa
Copy link
Contributor

@fmasa fmasa commented Sep 2, 2019 •
edited
Loading

Description

There was return type currently missing. Also property type was wrong as $parent can be null (i.e. for Section)

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.606% when pulling 8f4f4dc on fmasa:fix/return-types into 8fbd060 on PHPOffice:develop.

@fmasa
Copy link
Contributor Author

fmasa commented Sep 4, 2019

I just noticed that maybe type can be refined to AbstractContainer|null as only instances of AbstractContainer can have child elements.

@troosan troosan merged commit dfa0b5f into PHPOffice:develop Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fmasa @coveralls @troosan