Skip to content

Update composer.json #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 19 commits into from
Closed

Conversation

wandrewchan
Copy link

remove abandoned zend-escaper, replace with laminas

@troosan troosan added this to the v0.18.0 milestone Aug 30, 2020
@stephanvierkant
Copy link

stephanvierkant commented Sep 8, 2020

You also changed some other files. Can you explain those changes?

@internalsystemerror
Copy link

the latest version of laminas/laminas-escaper requires PHP >= 5.6

@stephanvierkant
Copy link

the latest version of laminas/laminas-escaper requires PHP >= 5.6

What's the point?

@internalsystemerror
Copy link

internalsystemerror commented Sep 15, 2020

U asked what the other changes were for. As far as I can see, those changes are removing the support for PHP < 5.6.

@stephanvierkant
Copy link

I mean files like src/PhpWord/Escaper/AbstractEscaper.php

@liborm85
Copy link
Contributor

Why is upgraded minimal php version? This is BC break. You can use "laminas/laminas-escaper": "^2.2",.

And PR contains other irrelevant changes in AbstractEscaper.php.
PR is wrong.

@stephanvierkant
Copy link

stephanvierkant commented Oct 18, 2020

Yes, in theory this might be a BC break. But it has been upgraded to a PHP version that hasn't got support for years now. I don't consider removing support for EOL-versions a BC-break.

But yeah, it has other irrelevant changes and that is a problem. @wandrewchan can you please change it?

@wandrewchan
Copy link
Author

Actually I was trying to replace with laminas as what @tacman, but it was failed. And I found that zend-escaper has deprecated, but it still works. So this merge is discard and closed.

@wandrewchan wandrewchan deleted the patch-2 branch October 18, 2020 11:02
@liborm85
Copy link
Contributor

liborm85 commented Oct 18, 2020

I'm adding compatibility with PHP 7.4 and PHP 8.0 in PR #1946, was necessary fix travis and scrutinizer. So also migrate to Laminas with compatibility PHP 5.3+, commit: f2516b0

@stephanvierkant
Copy link

That would be (at least) the third attempt to replace zend by laminas. And again, that PR contains other changes as well.

@liborm85
Copy link
Contributor

Without next changes it is not possible to test whether it works in travis.

@tacman
Copy link

tacman commented Dec 31, 2020

My PR was a one-line fix, and it gets rid of the warning that shows up every time. Was there a problem with that PR? Yes, at the moment the deprecated version still works, but there's no reason to keep it.

PHP 5 is dead, dead, dead. Anyone using it should upgrade. That's a different PR, of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants