-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Update composer.json #1916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update composer.json #1916
Conversation
remove abandoned zend-escaper, replace with laminas
You also changed some other files. Can you explain those changes? |
the latest version of laminas/laminas-escaper requires PHP >= 5.6 |
What's the point? |
U asked what the other changes were for. As far as I can see, those changes are removing the support for PHP < 5.6. |
I mean files like |
Why is upgraded minimal php version? This is BC break. You can use And PR contains other irrelevant changes in AbstractEscaper.php. |
Yes, in theory this might be a BC break. But it has been upgraded to a PHP version that hasn't got support for years now. I don't consider removing support for EOL-versions a BC-break. But yeah, it has other irrelevant changes and that is a problem. @wandrewchan can you please change it? |
Actually I was trying to replace with laminas as what @tacman, but it was failed. And I found that zend-escaper has deprecated, but it still works. So this merge is discard and closed. |
That would be (at least) the third attempt to replace zend by laminas. And again, that PR contains other changes as well. |
Without next changes it is not possible to test whether it works in travis. |
My PR was a one-line fix, and it gets rid of the warning that shows up every time. Was there a problem with that PR? Yes, at the moment the deprecated version still works, but there's no reason to keep it. PHP 5 is dead, dead, dead. Anyone using it should upgrade. That's a different PR, of course. |
remove abandoned zend-escaper, replace with laminas