Introduce deleteRow() method for TemplateProcessor #2104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs to be merged 🙏 |
|
+1 |
|
Why isn't this merged yet? I really need this but I don't want to create a custom fork just for this feature, |
|
Maybe I'll ping @Progi1984 @PowerKiKi as it has 5 years now! :D |
Progi1984
reviewed
Nov 3, 2022
Progi1984
reviewed
Nov 3, 2022
Progi1984
reviewed
Nov 3, 2022
Progi1984
reviewed
Nov 3, 2022
Progi1984
reviewed
Nov 3, 2022
Co-authored-by: Progi1984 <[email protected]>
Co-authored-by: Progi1984 <[email protected]>
Co-authored-by: Progi1984 <[email protected]>
simivar
force-pushed
the
feature/delete-row
branch
from
49f83a0 to
46e61d4
Compare
|
@Progi1984 thank you for the review, done |
Progi1984
approved these changes
Nov 7, 2022
|
@simivar Could you fix PHPCSFixer, please ? |
|
@Progi1984 done |
|
@Progi1984 kindly pinging 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#1017 done again after 4 years