Skip to content

Invalid Annotation in Test Member #2549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Conversation

oleibman
Copy link
Contributor

PhpUnit cannot parse the @covers lines in FormulaTest; they result in warnings in Coverage and Deploy tests. This PR fixes them; no change log entry should be needed.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes # (issue)

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes

PhpUnit cannot parse the `@covers` lines in FormulaTest; they result in warnings in Coverage and Deploy tests. This PR fixes them; no change log entry should be needed.
@coveralls
Copy link

coveralls commented Jan 15, 2024

Coverage Status

coverage: 97.217%. remained the same
when pulling f92acf1 on oleibman:invalidcov
into 41cf4eb on PHPOffice:master.

PhpWordTest ran in such a way that `new PhpWord()` and `new DocInfo()` happened in different seconds. Almost impossible, but easy enough to prevent.
@Progi1984 Progi1984 merged commit 2f4da6e into PHPOffice:master Jan 15, 2024
@Progi1984 Progi1984 added this to the 2.0.0 milestone Jan 15, 2024
@Progi1984 Progi1984 deleted the invalidcov branch January 15, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants