Skip to content

Extend HTML output for pagebreaks for PDF generation #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

chc88
Copy link
Contributor

@chc88 chc88 commented Nov 14, 2014

Make HTML output of pagebreak compatible for the different PDF writers by combining:
http://mpdf1.com/manual/index.php?tid=110 (tested and working)
and
https://code.google.com/p/dompdf/wiki/FAQ (tested and working)
and
http://chandeshparekh.com/css-to-create-new-page-in-php-tcpdf-pdf/

This is a pull-request for this issue: #426

Make HTML output of pagebreak compatible for the different PDF writers by combining:
http://mpdf1.com/manual/index.php?tid=110 (tested and working)
and
https://code.google.com/p/dompdf/wiki/FAQ (tested and working)
and
http://chandeshparekh.com/css-to-create-new-page-in-php-tcpdf-pdf/
@Progi1984
Copy link
Member

@chc88 Hi, could you :

  • add your contribution to the file CHANGELOG.MD ?
  • point your PR to the develop branch ?
  • test if you are in the PDF writer and not in the HTML Writer like there :
    if (!$parentWriter->isPdf()) {
    ?
  • and may be add some unit tests ?

Thanks for your job :)

Add new-page function for PDF generation. For multiple PDF-backends - @chc88 PHPOfficeGH-426
Update pdf-generation; check if we're generating a pdf
@chc88 chc88 closed this Dec 10, 2014
@Progi1984
Copy link
Member

The new PR is : #441.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants