-
-
Notifications
You must be signed in to change notification settings - Fork 453
Making use of a custom predis/redis client #598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello, This is a known limitation of the (P)redis driver and won't be done in v6 which is now stable. Cheers, |
@dol This should do the job. Test it please, so I can make some automated tests on my side too. |
@dol Bump :P |
The issue has been fixed, thanks you for your contribution 👍 Geolim4 |
@Geolim4 Thank you for implementing this. I was able to the implementation and I confirm it's working as excepted. |
Configuration:
PhpFastCache version:
6.*
PHP version:
PHP 7.0
Issue description:
The predis client can also be used with a Redis cluster/sentinel setup. https://github.com/nrk/predis#cluster
The current implementation and also v7 doesn't allow to use more than one server.
phpfastcache/src/phpFastCache/Drivers/Predis/Driver.php
Line 157 in 411cf0a
To allow all the possible predis settings the configurations parameters need to be passed to the client initialization. In v6 and v7 this is not possible due to a limited set of configuration settings and that are merge with the default settings.
One solution could be to pass the raw
$parameters
and$options
to the client initialization inside the driver or the add a new config parameter that allows a already Predis client object.E.g:
The text was updated successfully, but these errors were encountered: