Psr16Adapter should convert Traversable into array in deleteMultiple

[oskarakerlund]

Configuration

• PhpFastCache version: 7.0.5
• PHP version: 7.1

Describe the bug

The PSR-6 CacheItemPoolInterface requires an array as input to deleteItems however PSR-16 accepts an array or a Traversable as input to deleteMultiple. But in Psr16Adapter, the input is passed from deleteMultiple directly to deleteItems without checking if it is an array.

Using Psr16Adapter and calling deleteMultiple with the output from a generator function should work since it follows PSR-16. But currently it triggers an error:

Uncaught TypeError: Argument 1 passed to Phpfastcache\Drivers\Files\Driver::deleteItems() must be of the type array, object given, called in /var/www/vendor/phpfastcache/phpfastcache/lib/Phpfastcache/Helper/Psr16Adapter.php on line 178 and defined in /var/www/vendor/phpfastcache/phpfastcache/lib/Phpfastcache/Core/Pool/CacheItemPoolTrait.php:297
Stack trace:
#0 /var/www/vendor/phpfastcache/phpfastcache/lib/Phpfastcache/Helper/Psr16Adapter.php(178): Phpfastcache\Drivers\Files\Driver->deleteItems(Object(Generator))
#1 /var/www/vendor/phpoffice/phpspreadsheet/src/PhpSpreadsheet/Collection/Cells.php(492): Phpfastcache\Helper\Psr16Adapter->deleteMultiple(Object(Generator))

To Reproduce
Steps to reproduce the behavior:
Use the Psr16Adapter and call deleteMultiple using a generator function. PhpSpreadsheets does this.

Expected behavior
deleteMultiple should convert any Traversable to an array before calling deleteItems.

[Geolim4]

Hello !

Thanks for that issue, I'll take a look this weekend.

Cheers,
Georges

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[oskar-wikinggruppen]

@Geolim4 will you make sure this issue stays open?

[Geolim4]

Yeah, I'm a little sick these day, I will treat all the pending issues on a row :)