-
-
Notifications
You must be signed in to change notification settings - Fork 453
Update CouchBase driver connection function with new couchbase PHP SDK 2.4 #599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…K 2.4, port and bucket passwords are no longer required as of CouchBase 5.0
Hello @git-webmaster Thanks you for the contribution but I would prefer to make the pull request to the V7 rather than the "final" branch to preserve backward compatibility as Phpfastcache is Semver compliant ;) However you can add a notice in the driver class in the "final" branch to warn the users about this deprecations. Much appreciated, |
Hello @Geolim4 Thanks. |
Make a new pull request to the V7 with those changes (please test it carefully), the V7 being almost production ready it's not too late to apply this fix right now. The V6 (final) is now freezed to preserve backward compatibility. You can still make another PR to the v6 if you want with the only purpose to warn user about this deprecated behavior. |
Ok, i will make new PR. |
Good thing, I do love fairly tested code, thanks you for your contribution <3 |
Looks like you have changed the driver for CouchBase in V7. Example: you use According to url: This will not work with CouchBase 5 and you have to use
Also, you use this approach:
while i use this:
Unfortunatly, i am not able to test that new code you have, because i have different one and not allowed to break things on my side, so i think that PR with my code is no longer required. If you wish, i may change this connection function to new SDK, but this changes will not be tested. |
Then, don't PR now, you can do it someday when you will upgrade your code. |
Good morning @Geolim4 Here is the new 2 GB RAM Linode i just ordered:
It has Web root is Test file with couchbase connection and credentials: http://172.104.xxx.xxx/cb.php Couchbase admin is at: http://172.104..xxx.xxx:8091 login:xxx same. Feel free to do anything you need with this box. When you finish testing - please let me know, i will delete this linode in order not to waste money :) |
Hello, Can you send me all the sensitive information at "contact [nospam] geolim4.com" please ? Thanks you very much for providing me such resources ! Cheers, |
Sent you a mail. Thank you. |
I will probably begin my tests this weekend or in the very beginning of the next week, thanks. |
I just made the V7 update, hope it'll work on the first shoot :P |
Port and bucket passwords are no longer required as of CouchBase 5.0, and old connection code is not working due to the new authentification model.
I am using this code right now with new CouchBase server 5.1.0.
It is still possible to use "$port" in configuration array (despite it is no longer required), i leave a check for it - maybe will be useful in some non-standart environment.
Some links:
https://developer.couchbase.com/documentation/server/current/sdk/php/start-using-sdk.html