Skip to content

[AutoParallel] Fix fast_rms_norm #10711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 11, 2025
Merged

Conversation

Xing-lil
Copy link
Contributor

@Xing-lil Xing-lil commented Jun 6, 2025

Before submitting

  • Lint code. If there are lint issues, please format the code first.
# Install and register `pre-commit` in the project folder
pip install pre-commit && pre-commit install

# Process previous code files separately
pre-commit run --file XXXX.py
  • Add test cases into tests folder. If there are codecov issues, please add tests cases first.

PR types

Bug fixes

PR changes

Others

Description

Fix fast_rms_norm
The loss curve of llama13b_layer10_sd8 with fast_rms_norm true / false:
loss_fast_rms_norm

Copy link

paddle-bot bot commented Jun 6, 2025

Thanks for your contribution!

Copy link
Contributor

@liym27 liym27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI 里有动半 fast_layer_norm的测试吗

@Xing-lil
Copy link
Contributor Author

Xing-lil commented Jun 6, 2025

CI 里有动半 fast_layer_norm的测试吗

已添加动半llama验证fast_layer_norm的ci监控,感谢!

Copy link

codecov bot commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.93%. Comparing base (7309a5d) to head (9f79de3).
Report is 2 commits behind head on develop.

❌ Your project status has failed because the head coverage (46.93%) is below the target coverage (58.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #10711   +/-   ##
========================================
  Coverage    46.93%   46.93%           
========================================
  Files          800      800           
  Lines       132741   132741           
========================================
  Hits         62304    62304           
  Misses       70437    70437           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@liym27 liym27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZHUI ZHUI merged commit eb9e7a0 into PaddlePaddle:develop Jun 11, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants