-
Notifications
You must be signed in to change notification settings - Fork 3k
[AutoParallel] Fix fast_rms_norm #10711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI 里有动半 fast_layer_norm的测试吗
已添加动半llama验证fast_layer_norm的ci监控,感谢! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (46.93%) is below the target coverage (58.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #10711 +/- ##
========================================
Coverage 46.93% 46.93%
========================================
Files 800 800
Lines 132741 132741
========================================
Hits 62304 62304
Misses 70437 70437 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Before submitting
tests
folder. If there are codecov issues, please add tests cases first.PR types
Bug fixes
PR changes
Others
Description
Fix fast_rms_norm

The loss curve of llama13b_layer10_sd8 with fast_rms_norm true / false: