Skip to content

rename file format strings #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 9, 2024
Merged

rename file format strings #40

merged 2 commits into from
Aug 9, 2024

Conversation

Jonathanlyj
Copy link
Collaborator

rename 64BIT_OFFSET to NETCDF3_64BIT_OFFSET
rename 64BIT_DATA to NETCDF3_64BIT_DATA
add NETCDF3_64BIT_CLASSIC option, equivalent to None

@wkliao
Copy link
Member

wkliao commented Aug 8, 2024

I suggest we rename 64BIT_OFFSET to NC_64BIT_OFFSET
and 64BIT_DATA to NC_ 64BIT_DATA, so they appear the same
as the C constant.

In addition, we also add the ones used in NetCDF4-python.
So, NETCDF3_64BIT_CLASSIC is the same as NC_64BIT_OFFSET
and NETCDF3_ 64BIT_DATA is the same as NC_ 64BIT_DATA

@wkliao wkliao merged commit 14bc618 into main Aug 9, 2024
3 checks passed
@wkliao wkliao deleted the rename_file_format branch August 9, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants