Skip to content

Move getXXX functions to methods #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jun9358 opened this issue Jul 20, 2017 · 4 comments
Closed

Move getXXX functions to methods #64

jun9358 opened this issue Jul 20, 2017 · 4 comments
Labels

Comments

@jun9358
Copy link

jun9358 commented Jul 20, 2017

I want to override functions(getScrollParent, getCurrentDistance) using extends options (http://vuejs.org/v2/api/#extends)
(For non-scrolling iframe support - use scrollParent to iframe's parent body, but i think this is not good idea support it basically in this library)

So, could you move these functions to vuejs' methods?

@PeachScript
Copy link
Owner

Sounds a good idea! I will move functions to methods in the next version. For now, this part of the documentation maybe useful for you.

@jun9358
Copy link
Author

jun9358 commented Aug 17, 2017

I forked and moved those functions, and using it now.
Thank you for accepting my suggestion.

@PeachScript
Copy link
Owner

Hi @jun9358 , v2.2.0 has been released, include this change, you can try it now, please feedback to here if you find any problem, thanks :D

@jun9358
Copy link
Author

jun9358 commented Sep 20, 2017

PERFECT! @PeachScript , thanks~

@jun9358 jun9358 closed this as completed Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants