Skip to content

add name attribute to InfiniteLoading component #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2017

Conversation

rquelen
Copy link
Contributor

@rquelen rquelen commented Nov 13, 2017

Hello,

Using vue-test-utils, we need the name attribute to be set on the component if we want to find it in the template.

For example :

it('should contain infinite loading component', () => {
      // when
      const wrapper = shallow(LatestNews);

      // then
      const infiniteLoadingComponents = wrapper.findAll(InfiniteLoading);
      expect(infiniteLoadingComponents.length).toEqual(1);
});

Thank you

@codecov
Copy link

codecov bot commented Nov 13, 2017

Codecov Report

Merging #108 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #108   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          90     90           
  Branches       24     24           
=====================================
  Hits           90     90
Impacted Files Coverage Δ
src/components/InfiniteLoading.vue 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5dd95f...4b232a7. Read the comment docs.

@PeachScript
Copy link
Owner

Nick work, thank you!

@PeachScript PeachScript merged commit 2f2a235 into PeachScript:master Nov 15, 2017
@damienbeaufils
Copy link

Thanks for the PR!
@PeachScript I'm waiting for this feature too. Do you think it will be released soon?

@PeachScript
Copy link
Owner

@damienbeaufils got it, I will release a new version today :P

@damienbeaufils
Copy link

@PeachScript Thanks!

@PeachScript
Copy link
Owner

@damienbeaufils the new version v2.2.2 has been released.

@damienbeaufils
Copy link

@PeachScript Awesome! But there is a little mistake on the release note: I’m not the contributor of this PR, it’s @rquelen ;)

@PeachScript
Copy link
Owner

@damienbeaufils oh it's my fault, thanks for your reminding!

And I'm sorry for this @rquelen , it has been corrected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants