Update versions for 1.18.0 Release #1174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergmeister
approved these changes
Mar 14, 2019
bergmeister
reviewed
Mar 14, 2019
| @@ -18,7 +18,7 @@ RUN Import-Module PackageManagement; ` | |||
| Install-ChocolateyPackage -PackageName nuget.commandline -Executable nuget.exe -Cleanup; ` | |||
| Install-Module -Force -Name platyPS; ` | |||
| Invoke-WebRequest -Uri https://raw.githubusercontent.com/dotnet/cli/master/scripts/obtain/dotnet-install.ps1 -outfile C:/dotnet-install.ps1; ` | |||
| C:/dotnet-install.ps1 -Channel Release -Version 2.2.3; ` | |||
| C:/dotnet-install.ps1 -Channel Release -Version 2.1.4; ` | |||
There was a problem hiding this comment.
Have you tried using the latest patched version 2.1.9? Maybe it was an issue of the 2.2 version not containing the 2.1 runtime that was needed for something?
Suggested change
| C:/dotnet-install.ps1 -Channel Release -Version 2.1.4; ` | |
| C:/dotnet-install.ps1 -Channel Release -Version 2.1.9; ` |
There was a problem hiding this comment.
sadly, that build fails as well. I'm not too fussed about this, as it's just the build tool which is used in the docker image. I can tear this apart after this release.
This reverts commit dd353a0.
bergmeister
pushed a commit
to bergmeister/PSScriptAnalyzer
that referenced
this pull request
Mar 22, 2019
* Drop back to 2.1.4 for sdk in container * Don't take input for building, the release tag is never used * Push version to 1.18.0 * add param statement in vstsbuild script * add dummy ReleaseTag * Move up to sdk 2.1.9 * Revert "Move up to sdk 2.1.9" This reverts commit dd353a0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
updates for building in vsts
change version in
.psd1to 1.18.0change version in
.csprojto 1.18.0revert back to 2.1.4 sdk version in container build
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.