-
Notifications
You must be signed in to change notification settings - Fork 52
Add domain classes for study selected series and selection operator #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6490e09
to
a1eb2d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Looks good to me.
Please commit with a signature and fix style check failures.
@gigony thanks for your input. Will make changes soon and push. |
77202a8
to
6920d20
Compare
I ran But getting the error in the build check Oh well. |
37222bc
to
bec2cd4
Compare
Signed-off-by: mmelqin <[email protected]>
Signed-off-by: mmelqin <[email protected]>
…t in inference yet. Signed-off-by: mmelqin <[email protected]>
Signed-off-by: mmelqin <[email protected]>
Signed-off-by: mmelqin <[email protected]>
Signed-off-by: mmelqin <[email protected]>
Signed-off-by: mmelqin <[email protected]>
Signed-off-by: mmelqin <[email protected]>
Signed-off-by: mmelqin <[email protected]>
1 file reformatted, 113 files left unchanged Signed-off-by: mmelqin <[email protected]>
Signed-off-by: mmelqin <[email protected]>
Signed-off-by: mmelqin <[email protected]>
Signed-off-by: mmelqin <[email protected]>
Signed-off-by: mmelqin <[email protected]>
Signed-off-by: mmelqin <[email protected]>
Signed-off-by: mmelqin <[email protected]>
Signed-off-by: mmelqin <[email protected]>
Adding domain classes SeletedSeries and StudySelectedSeries, with the former encapsulate the selection name, DICOMSeries, and Image if applicable. The SelectedSeries are contained as a list in a DICOMStudy.
Adding simple selection rules in JSON, matching on DICOM Study and Series module attributes, limited to those exposed by DICOMStudy and DICOMSeries.
Adding selection logic in the DICOMSeriesSelection operator, as well as changing the output to list of StudySelectedSeries objects. It is extendable, and custom operators can be chained.
Update the DICOMSeriesToVolumeOperator to take in list of StudySelectedSeries object, and convert all series, though still limited to output the first series' image, as the inference operator can only support one input image.
Update operators'
test
methods.Updated applicable example applications and Jupyter notebook to use the new API.
Updated domain classes to comply with DICOM Keywords for properties.
Updated DICOM loading operator to set domain objects' properties correctly.
Note: the style checker in the build/test fails because it complains about the camel case of the DICOM keyword properties of the DICOMStudy and DICOMSeries class, but it is best to use DICOM Standards based keywords names than the Python preferred naming convention (Pydicom also uses DICOM keywords as properties, so it is also consistent)