-
Notifications
You must be signed in to change notification settings - Fork 52
Remove developer names/aliases from notebooks and documentation #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -162,7 +162,7 @@ | |
"remote: Total 274 (delta 127), reused 213 (delta 90), pack-reused 0\u001b[K\n", | ||
"Receiving objects: 100% (274/274), 79.20 KiB | 705.00 KiB/s, done.\n", | ||
"Resolving deltas: 100% (127/127), done.\n", | ||
"/home/kavink/src/work_folder/monai-deploy-app-sdk/notebooks/tutorials/monai-deploy-app-server/components/inference-service\n", | ||
"~/src/monai-deploy-app-sdk/notebooks/tutorials/monai-deploy-app-server/components/inference-service\n", | ||
"\n", | ||
"Step 1/12 : FROM python:3.9-slim-buster\n", | ||
" ---> edd87973afe0\n", | ||
|
@@ -201,7 +201,7 @@ | |
" ---> a6834eb5a23b\n", | ||
"Successfully built a6834eb5a23b\n", | ||
"Successfully tagged monai/inference-service:0.1\n", | ||
"/home/kavink/src/work_folder/monai-deploy-app-sdk/notebooks/tutorials\n" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can we replace /home/ with ~ ? |
||
"~/src/monai-deploy-app-sdk/notebooks/tutorials\n" | ||
] | ||
} | ||
], | ||
|
@@ -230,7 +230,7 @@ | |
"text": [ | ||
"Downloading...\n", | ||
"From: https://drive.google.com/uc?id=12uNO1tyqZh1oFkZH41Osliey7TRm-BBG\n", | ||
"To: /home/kavink/src/work_folder/monai-deploy-app-sdk/notebooks/tutorials/charts.zip\n", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can we replace /home/ with ~ ? |
||
"To: ~/src/monai-deploy-app-sdk/notebooks/tutorials/charts.zip\n", | ||
"100%|██████████████████████████████████████| 9.18k/9.18k [00:00<00:00, 10.9MB/s]\n", | ||
"Archive: charts.zip\n", | ||
" inflating: charts/templates/monaiinferenceservice-deployment.yaml \n", | ||
|
@@ -260,8 +260,8 @@ | |
"\n", | ||
"| Parameter | Value Description |\n", | ||
"| ----------- | ----------- |\n", | ||
"| `images.monaiInferenceServiceTag` | MONAI Inference Service image name (`pritishnahar/monai-deploy`) |\n", | ||
"| `images.monaiInferenceService` | MONAI Inference Service image tag (`inference-service-0.1`) |\n", | ||
"| `images.monaiInferenceService` | MONAI Inference Service image name (`monai/inference-service`) |\n", | ||
"| `images.monaiInferenceServiceTag` | MONAI Inference Service image tag (`0.1`) |\n", | ||
"| `payloadService.hostVolumePath` | Path to a local directory which will serve as a shared volume for payloads between MIS and its pods |\n", | ||
"| `map.urn` | Name:Tag of MAP image built with MONAI application packager |\n", | ||
"| `map.entrypoint` | Application entrypoint which can obtained from `app.json` |\n", | ||
|
@@ -453,7 +453,7 @@ | |
"Requirement already satisfied: PySocks!=1.5.7,>=1.5.6 in /home/gupta/miniconda3/envs/monairsna/lib/python3.6/site-packages (from requests[socks]->gdown) (1.7.1)\n", | ||
"Downloading...\n", | ||
"From: https://drive.google.com/uc?id=1GC_N8YQk_mOWN02oOzAU_2YDmNRWk--n\n", | ||
"To: /data/Vikash/Tools/RSNA/monai-deploy-app-sdk/notebooks/tutorials/ai_spleen_seg_data_updated_1203.zip\n", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we should standardize this path so that it copy/pasted it just works. |
||
"To: ~/src/monai-deploy-app-sdk/notebooks/tutorials/ai_spleen_seg_data_updated_1203.zip\n", | ||
"100%|████████████████████████████████████████| 104M/104M [00:20<00:00, 4.97MB/s]\n", | ||
"Archive: ai_spleen_seg_data_updated_1203.zip\n", | ||
" inflating: dcm/IMG0001.dcm \n", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -129,7 +129,7 @@ | |
"Requirement already satisfied: PySocks!=1.5.7,>=1.5.6 in /home/gbae/miniconda3/envs/mednist/lib/python3.6/site-packages (from requests[socks]>=2.12.0->gdown) (1.7.1)\n", | ||
"Downloading...\n", | ||
"From: https://drive.google.com/uc?id=1GC_N8YQk_mOWN02oOzAU_2YDmNRWk--n\n", | ||
"To: /home/gbae/repo/monai-deploy-app-sdk/notebooks/tutorials/ai_spleen_seg_data_updated_1203.zip\n", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can we replace we should also standardize the path we use. I recommend using There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
We can also use a variable the repopath, eg: |
||
"To: ~/src/monai-deploy-app-sdk/notebooks/tutorials/ai_spleen_seg_data_updated_1203.zip\n", | ||
"104MB [00:10, 10.3MB/s] \n", | ||
"Archive: ai_spleen_seg_data_update_1203.zip\n", | ||
" creating: dcm/\n", | ||
|
@@ -905,7 +905,7 @@ | |
"name": "stdout", | ||
"output_type": "stream", | ||
"text": [ | ||
"file written: /home/gbae/repo/monai-deploy-app-sdk/notebooks/tutorials/output/prediction_output/Img_in_context/Img_in_context_seg.nii.gz.\n", | ||
"file written: ~/src/monai-deploy-app-sdk/notebooks/tutorials/output/prediction_output/Img_in_context/Img_in_context_seg.nii.gz.\n", | ||
"Output Seg image numpy array shaped: (515, 440, 440)\n", | ||
"Output Seg image pixel max value: 1\n", | ||
"\u001b[34mDone performing execution of operator SpleenSegOperator\n", | ||
|
@@ -919,7 +919,7 @@ | |
"output_type": "stream", | ||
"text": [ | ||
"[2021-09-23 02:20:19,972] [INFO] (monai.deploy.operators.dicom_seg_writer_operator.DICOMSegWriter) - Unique values in seg image: [0 1]\n", | ||
"[2021-09-23 02:20:21,118] [INFO] (monai.deploy.operators.dicom_seg_writer_operator.DICOMSegWriter) - Saving output file /home/gbae/repo/monai-deploy-app-sdk/notebooks/tutorials/output/dicom_seg-DICOMSEG.dcm\n", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can we replace |
||
"[2021-09-23 02:20:21,118] [INFO] (monai.deploy.operators.dicom_seg_writer_operator.DICOMSegWriter) - Saving output file ~/src/monai-deploy-app-sdk/notebooks/tutorials/output/dicom_seg-DICOMSEG.dcm\n", | ||
"[2021-09-23 02:20:21,397] [INFO] (monai.deploy.operators.dicom_seg_writer_operator.DICOMSegWriter) - File saved.\n" | ||
] | ||
}, | ||
|
@@ -1257,7 +1257,7 @@ | |
"\u001b[39m\n", | ||
"\u001b[34mGoing to initiate execution of operator SpleenSegOperator\u001b[39m\n", | ||
"\u001b[32mExecuting operator SpleenSegOperator \u001b[33m(Process ID: 5326, Operator ID: a46c7abc-1f90-4009-80d2-0804b23221db)\u001b[39m\n", | ||
"file written: /home/gbae/repo/monai-deploy-app-sdk/notebooks/tutorials/output/prediction_output/Img_in_context/Img_in_context_seg.nii.gz.\n", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can we replace |
||
"file written: ~/src/monai-deploy-app-sdk/notebooks/tutorials/output/prediction_output/Img_in_context/Img_in_context_seg.nii.gz.\n", | ||
"Output Seg image numpy array shaped: (515, 440, 440)\n", | ||
"Output Seg image pixel max value: 1\n", | ||
"\u001b[34mDone performing execution of operator SpleenSegOperator\n", | ||
|
@@ -1268,7 +1268,7 @@ | |
"[2021-09-23 02:20:31,260] [INFO] (monai.deploy.operators.dicom_seg_writer_operator.DICOMSegWriter) - Number of slices in the numpy image: 515\n", | ||
"[2021-09-23 02:20:31,260] [INFO] (monai.deploy.operators.dicom_seg_writer_operator.DICOMSegWriter) - Labels of the segments: ['Spleen']\n", | ||
"[2021-09-23 02:20:33,355] [INFO] (monai.deploy.operators.dicom_seg_writer_operator.DICOMSegWriter) - Unique values in seg image: [0 1]\n", | ||
"[2021-09-23 02:20:34,659] [INFO] (monai.deploy.operators.dicom_seg_writer_operator.DICOMSegWriter) - Saving output file /home/gbae/repo/monai-deploy-app-sdk/notebooks/tutorials/output/dicom_seg-DICOMSEG.dcm\n", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can we replace |
||
"[2021-09-23 02:20:34,659] [INFO] (monai.deploy.operators.dicom_seg_writer_operator.DICOMSegWriter) - Saving output file ~/src/monai-deploy-app-sdk/notebooks/tutorials/output/dicom_seg-DICOMSEG.dcm\n", | ||
"[2021-09-23 02:20:34,846] [INFO] (monai.deploy.operators.dicom_seg_writer_operator.DICOMSegWriter) - File saved.\n", | ||
"\u001b[34mDone performing execution of operator DICOMSegmentationWriterOperator\n", | ||
"\u001b[39m\n" | ||
|
@@ -1309,7 +1309,7 @@ | |
"\u001b[39m\n", | ||
"\u001b[34mGoing to initiate execution of operator SpleenSegOperator\u001b[39m\n", | ||
"\u001b[32mExecuting operator SpleenSegOperator \u001b[33m(Process ID: 5905, Operator ID: 33da2642-2729-46ea-afe0-632e2a1ae5fc)\u001b[39m\n", | ||
"file written: /home/gbae/repo/monai-deploy-app-sdk/notebooks/tutorials/output/prediction_output/Img_in_context/Img_in_context_seg.nii.gz.\n", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can we replace |
||
"file written: ~/src/monai-deploy-app-sdk/notebooks/tutorials/output/prediction_output/Img_in_context/Img_in_context_seg.nii.gz.\n", | ||
"Output Seg image numpy array shaped: (515, 440, 440)\n", | ||
"Output Seg image pixel max value: 1\n", | ||
"\u001b[34mDone performing execution of operator SpleenSegOperator\n", | ||
|
@@ -1320,7 +1320,7 @@ | |
"[2021-09-23 02:20:44,984] [INFO] (monai.deploy.operators.dicom_seg_writer_operator.DICOMSegWriter) - Number of slices in the numpy image: 515\n", | ||
"[2021-09-23 02:20:44,984] [INFO] (monai.deploy.operators.dicom_seg_writer_operator.DICOMSegWriter) - Labels of the segments: ['Spleen']\n", | ||
"[2021-09-23 02:20:47,101] [INFO] (monai.deploy.operators.dicom_seg_writer_operator.DICOMSegWriter) - Unique values in seg image: [0 1]\n", | ||
"[2021-09-23 02:20:48,312] [INFO] (monai.deploy.operators.dicom_seg_writer_operator.DICOMSegWriter) - Saving output file /home/gbae/repo/monai-deploy-app-sdk/notebooks/tutorials/output/dicom_seg-DICOMSEG.dcm\n", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can we replace |
||
"[2021-09-23 02:20:48,312] [INFO] (monai.deploy.operators.dicom_seg_writer_operator.DICOMSegWriter) - Saving output file ~/src/monai-deploy-app-sdk/notebooks/tutorials/output/dicom_seg-DICOMSEG.dcm\n", | ||
"[2021-09-23 02:20:48,513] [INFO] (monai.deploy.operators.dicom_seg_writer_operator.DICOMSegWriter) - File saved.\n", | ||
"\u001b[34mDone performing execution of operator DICOMSegmentationWriterOperator\n", | ||
"\u001b[39m\n" | ||
|
@@ -1683,7 +1683,7 @@ | |
"remote: Total 274 (delta 127), reused 213 (delta 90), pack-reused 0\u001b[K\n", | ||
"Receiving objects: 100% (274/274), 79.20 KiB | 705.00 KiB/s, done.\n", | ||
"Resolving deltas: 100% (127/127), done.\n", | ||
"/home/kavink/src/work_folder/monai-deploy-app-sdk/notebooks/tutorials/monai-deploy-app-server/components/inference-service\n", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can we replace |
||
"~/src/monai-deploy-app-sdk/notebooks/tutorials/monai-deploy-app-server/components/inference-service\n", | ||
"\n", | ||
"Step 1/12 : FROM python:3.9-slim-buster\n", | ||
" ---> edd87973afe0\n", | ||
|
@@ -1722,7 +1722,7 @@ | |
" ---> a6834eb5a23b\n", | ||
"Successfully built a6834eb5a23b\n", | ||
"Successfully tagged monai/inference-service:0.1\n", | ||
"/home/kavink/src/work_folder/monai-deploy-app-sdk/notebooks/tutorials\n" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can we replace |
||
"~/src/monai-deploy-app-sdk/notebooks/tutorials\n" | ||
] | ||
} | ||
], | ||
|
@@ -1751,7 +1751,7 @@ | |
"text": [ | ||
"Downloading...\n", | ||
"From: https://drive.google.com/uc?id=12uNO1tyqZh1oFkZH41Osliey7TRm-BBG\n", | ||
"To: /home/kavink/src/work_folder/monai-deploy-app-sdk/notebooks/tutorials/charts.zip\n", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can we replace |
||
"To: ~/src/monai-deploy-app-sdk/notebooks/tutorials/charts.zip\n", | ||
"100%|██████████████████████████████████████| 9.18k/9.18k [00:00<00:00, 10.9MB/s]\n", | ||
"Archive: charts.zip\n", | ||
" inflating: charts/templates/monaiinferenceservice-deployment.yaml \n", | ||
|
@@ -1781,8 +1781,8 @@ | |
"\n", | ||
"| Parameter | Value Description |\n", | ||
"| ----------- | ----------- |\n", | ||
"| `images.monaiInferenceServiceTag` | MONAI Inference Service image name (`pritishnahar/monai-deploy`) |\n", | ||
"| `images.monaiInferenceService` | MONAI Inference Service image tag (`inference-service-0.1`) |\n", | ||
"| `images.monaiInferenceService` | MONAI Inference Service image name (`monai/inference-service`) |\n", | ||
"| `images.monaiInferenceServiceTag` | MONAI Inference Service image tag (`0.1`) |\n", | ||
"| `payloadService.hostVolumePath` | Path to a local directory which will serve as a shared volume for payloads between MIS and its pods |\n", | ||
"| `map.urn` | Name:Tag of MAP image built with MONAI application packager |\n", | ||
"| `map.entrypoint` | Application entrypoint which can obtained from `app.json` |\n", | ||
|
@@ -2042,7 +2042,7 @@ | |
"name": "stderr", | ||
"output_type": "stream", | ||
"text": [ | ||
"/home/kavink/.local/lib/python3.8/site-packages/nilearn/datasets/__init__.py:93: FutureWarning: Fetchers from the nilearn.datasets module will be updated in version 0.9 to return python strings instead of bytes and Pandas dataframes instead of Numpy arrays.\n", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can we replace |
||
"~/.local/lib/python3.8/site-packages/nilearn/datasets/__init__.py:93: FutureWarning: Fetchers from the nilearn.datasets module will be updated in version 0.9 to return python strings instead of bytes and Pandas dataframes instead of Numpy arrays.\n", | ||
" warn(\"Fetchers from the nilearn.datasets module will be \"\n" | ||
] | ||
}, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we replace
/home/<user>
with~
?