Skip to content

Nuance PIN MONAI Integration Example App #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 44 commits into from
Sep 21, 2022

Conversation

aihsani
Copy link
Contributor

@aihsani aihsani commented Aug 16, 2022

Creating an example integration app to allow MONAI users to run existing MONAI apps in Nuance's PIN network.

This integration is currently only for users/developers with access to the Nuance PIN SDK.

@aihsani aihsani requested review from gigony, CPBridge and MMelQin August 16, 2022 19:47
@aihsani aihsani self-assigned this Aug 16, 2022
@dbericat
Copy link
Member

Love this PR!

I'd like to place it somewhere else though, rather than /examples.

I think it would be better to have an /integrations folder. Then a subfolder with /marketplaces/nuance_pin . Then another subfolder with other OSS communities like medperf and the linux foundation. Etc.

These integrations are key and hugely invaluable for the success of the SDK. I feel like putting them under /examples hide them and lower the value.

Thoughts? @aihsani @MMelQin @rahul-imaging @gigony @brad @CPBridge

@MMelQin
Copy link
Collaborator

MMelQin commented Aug 16, 2022

Love this PR!

I'd like to place it somewhere else though, rather than /examples.

I think it would be better to have an /integrations folder. Then a subfolder with /marketplaces/nuance_pin . Then another subfolder with other OSS communities like medperf and the linux foundation. Etc.

These integrations are key and hugely invaluable for the success of the SDK. I feel like putting them under /examples hide them and lower the value.

Thoughts? @aihsani @MMelQin @rahul-imaging @gigony @brad @CPBridge

I discussed with Alvin earlier on where to place this adaptation code, and a folder under examples seemed to be a good candidate for now. The main reason is that this piece is not in the App SDK PyPi package proper, at for now, so it only lives in the repo, as an "example"

We can consider and discuss along the lines of extensions, integrations, applications etc., and rename/reshuffle the examples and notebook folder if need be.

@MMelQin MMelQin requested a review from rahul-imaging August 17, 2022 00:02
@MMelQin
Copy link
Collaborator

MMelQin commented Aug 18, 2022

I've also created a discussion topic on integration maturity level, #330. A good organization of folders will help a reader to navigate, but still have limitations without properly addressing use case in the App SDK proper.

@MMelQin MMelQin requested a review from nuance-iain August 18, 2022 08:15
Copy link
Collaborator

@CPBridge CPBridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aihsani, thanks so much for putting this together. I still need to finish testing it on our end so may have some more feedback then but I'm posting some minor documentation typos etc I spotted on the way

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aihsani
Copy link
Contributor Author

aihsani commented Sep 21, 2022

Love this PR!
I'd like to place it somewhere else though, rather than /examples.
I think it would be better to have an /integrations folder. Then a subfolder with /marketplaces/nuance_pin . Then another subfolder with other OSS communities like medperf and the linux foundation. Etc.
These integrations are key and hugely invaluable for the success of the SDK. I feel like putting them under /examples hide them and lower the value.
Thoughts? @aihsani @MMelQin @rahul-imaging @gigony @brad @CPBridge

I discussed with Alvin earlier on where to place this adaptation code, and a folder under examples seemed to be a good candidate for now. The main reason is that this piece is not in the App SDK PyPi package proper, at for now, so it only lives in the repo, as an "example"

We can consider and discuss along the lines of extensions, integrations, applications etc., and rename/reshuffle the examples and notebook folder if need be.

I've updated the location to /integration to increase profile

@aihsani aihsani merged commit 63b309e into Project-MONAI:main Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants