-
Notifications
You must be signed in to change notification settings - Fork 52
Nuance PIN MONAI Integration Example App #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Love this PR! I'd like to place it somewhere else though, rather than /examples. I think it would be better to have an /integrations folder. Then a subfolder with /marketplaces/nuance_pin . Then another subfolder with other OSS communities like medperf and the linux foundation. Etc. These integrations are key and hugely invaluable for the success of the SDK. I feel like putting them under /examples hide them and lower the value. Thoughts? @aihsani @MMelQin @rahul-imaging @gigony @brad @CPBridge |
I discussed with Alvin earlier on where to place this adaptation code, and a folder under We can consider and discuss along the lines of extensions, integrations, applications etc., and rename/reshuffle the |
I've also created a discussion topic on integration maturity level, #330. A good organization of folders will help a reader to navigate, but still have limitations without properly addressing use case in the App SDK proper. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @aihsani, thanks so much for putting this together. I still need to finish testing it on our end so may have some more feedback then but I'm posting some minor documentation typos etc I spotted on the way
Co-authored-by: Chris Bridge <[email protected]>
Co-authored-by: Chris Bridge <[email protected]>
Co-authored-by: Chris Bridge <[email protected]>
Co-authored-by: Chris Bridge <[email protected]>
Signed-off-by: Alvin Ihsani <[email protected]>
Signed-off-by: Alvin Ihsani <[email protected]>
Signed-off-by: Alvin Ihsani <[email protected]>
Kudos, SonarCloud Quality Gate passed!
|
I've updated the location to |
Creating an example integration app to allow MONAI users to run existing MONAI apps in Nuance's PIN network.
This integration is currently only for users/developers with access to the Nuance PIN SDK.