-
Notifications
You must be signed in to change notification settings - Fork 52
Various fixes to PIN integration example #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This may not be exactly what you are seeking for, but to achieve this we use NV container base, and run docker with GPU options ( |
Signed-off-by: Christopher Bridge <[email protected]>
42e5c61
to
16bb2d1
Compare
Signed-off-by: Christopher Bridge <[email protected]>
Signed-off-by: Christopher Bridge <[email protected]>
Thanks Min, but this hasn't been working for me. It's ok, no need to worry about his here.
Rebased, and fixed some style issues (that bizarrely were not caught before) |
Ready to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Christopher Bridge <[email protected]>
@aihsani I made a couple of small tweaks to the README, as we discussed on slack. I think we are ready to merge |
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @aihsani
Thanks again for this nice integration example and sorry for taking so long to get around to looking over it properly. I just played around with it for a while and it seems to be working quite nicely. During this process, I made a bunch of small changes, which I've collected in this pull request: