Skip to content

Add the missing python package, PyPDF2 #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2022
Merged

Conversation

MMelQin
Copy link
Collaborator

@MMelQin MMelQin commented Oct 16, 2022

The dependency introduced by the DICOM PDF Writer needs to be added to the requirements as well as in the Operator package list.
Also removed the spaces in a requirements file.

@MMelQin MMelQin force-pushed the mqin/add_missing_req_pyPDF2 branch from 309d9eb to 509f440 Compare October 16, 2022 05:13
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@MMelQin MMelQin linked an issue Oct 16, 2022 that may be closed by this pull request
@MMelQin MMelQin self-assigned this Oct 16, 2022
@MMelQin MMelQin requested a review from mingxin-zheng October 16, 2022 05:17
@vikashg
Copy link
Collaborator

vikashg commented Oct 16, 2022

Hi @MMelQin,
I am trying to test this using a TCIA dataset as I see in the test function in the dicom_encapsulated_pdf_writer_operator.py
Does it need any TestPDF.pdf file.
I am missing this file in the repo to complete the test.

@MMelQin
Copy link
Collaborator Author

MMelQin commented Oct 16, 2022

Hi @MMelQin, I am trying to test this using a TCIA dataset as I see in the test function in the dicom_encapsulated_pdf_writer_operator.py Does it need any TestPDF.pdf file. I am missing this file in the repo to complete the test.

Sorry the test data/file are not going into the repo. I used MS Word to generated a TestPDF.pdf file.

@vikashg
Copy link
Collaborator

vikashg commented Oct 16, 2022

Hi @MMelQin I do not have any issue with this merge everything works I tested. However, we must think of a proper example

@MMelQin
Copy link
Collaborator Author

MMelQin commented Oct 16, 2022

Hi @MMelQin I do not have any issue with this merge everything works I tested. However, we must think of a proper example

Thanks @vikashg . Good idea to provide examples! I can think of a classification application where after the inference a custom operator is used to convert the results into PDF and textual report, and then both the DICOM Encapsulated PDF and Simple Test SR Writer are used to wrap the content into corresponding DICOM objects.

Currently we have the MEDNIST example app that uses the Text SR writer, and maybe it can be extended to include a text/html to PDF operator.

I have some code based on headless-pdfkit, though it needs the wkhtmltopdf and xvfb-run wrapper. There is also the fpdf which can directly convert text to PDF with a bit of formatting info. So, we'll leave it to the app dev to pick which one is more appropriate for the use case.

@MMelQin MMelQin requested a review from vikashg October 16, 2022 18:14
Copy link
Collaborator

@vikashg vikashg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its all good and working for me

@MMelQin MMelQin merged commit 6cdc09d into main Oct 17, 2022
@MMelQin MMelQin deleted the mqin/add_missing_req_pyPDF2 branch March 17, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] module import error
3 participants