-
Notifications
You must be signed in to change notification settings - Fork 52
Add the missing python package, PyPDF2 #372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: M Q <[email protected]>
Signed-off-by: M Q <[email protected]>
309d9eb
to
509f440
Compare
Kudos, SonarCloud Quality Gate passed!
|
Hi @MMelQin, |
Sorry the test data/file are not going into the repo. I used MS Word to generated a TestPDF.pdf file. |
Hi @MMelQin I do not have any issue with this merge everything works I tested. However, we must think of a proper example |
Thanks @vikashg . Good idea to provide examples! I can think of a classification application where after the inference a custom operator is used to convert the results into PDF and textual report, and then both the DICOM Encapsulated PDF and Simple Test SR Writer are used to wrap the content into corresponding DICOM objects. Currently we have the MEDNIST example app that uses the Text SR writer, and maybe it can be extended to include a text/html to PDF operator. I have some code based on headless-pdfkit, though it needs the wkhtmltopdf and xvfb-run wrapper. There is also the fpdf which can directly convert text to PDF with a bit of formatting info. So, we'll leave it to the app dev to pick which one is more appropriate for the use case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its all good and working for me
The dependency introduced by the DICOM PDF Writer needs to be added to the requirements as well as in the Operator package list.
Also removed the spaces in a requirements file.