Fix runtime error for MAP of breast density classification app #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

MMelQin merged 1 commit into main from mqin/breast_density_fix_for_MAP

Nov 3, 2022

Collaborator

MMelQin commented Nov 3, 2022 •

edited

Loading

Needed to provided this fix after building and testing MAP of the breast density classification app

Somehow highdicom dependency is dragged in. Add this package in the App pip_packages decorator to avoid runtime error.
Need to change the app.py main function to directly init and run the app object, because the packager sets the command to run app.py instead of app/. Need to rename the original main() which served as test function to test()
Published the MAP on ghcr.io, http://ghcr.io/mmelqin/monai_ai_breast_density_cls_app:1.0, to be used as a candidate in the AWS Imaging Service integration demo

Signed-off-by: M Q [email protected]


          Make app.py's __main__ to init and run the app, as this is how MAP is…

04b52c3

… run

Signed-off-by: M Q <[email protected]>

MMelQin requested review from vikashg and GreySeaWolf

November 3, 2022 01:42

MMelQin self-assigned this

sonarqubecloud bot commented Nov 3, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

vikashg approved these changes

View reviewed changes

Collaborator

vikashg left a comment

Thanks @MMelQin I tested it works.

MMelQin merged commit affec70 into main

MMelQin deleted the mqin/breast_density_fix_for_MAP branch

March 17, 2023 20:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet