Skip to content

HL7v2 MLLP Listener #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 4, 2022
Merged

HL7v2 MLLP Listener #103

merged 6 commits into from
Aug 4, 2022

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Jul 15, 2022

Fixes #8 .

Description

  • An HL7v2 MLLP listener that listens on port 2575 (default, configurable), receives streams, validates messages (using HL7-dotnetcore).
  • The listener can be configured to send an acknowledgment or only respond based on the MSH value indicated in MSH-15.
  • Number of concurrent connections can be configured with default set to 10.
  • Additional configuration may be found in appsettings.json under InformaticsGateway>hl7 or in the Hl7Configuration.cs file.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@mocsharp mocsharp added the feature A new feature label Jul 15, 2022
@mocsharp mocsharp added this to the 0.3.0 milestone Jul 15, 2022
@mocsharp mocsharp self-assigned this Jul 15, 2022
@mocsharp mocsharp mentioned this pull request Jul 15, 2022
4 tasks
@mocsharp mocsharp force-pushed the vchang/hl7v2 branch 2 times, most recently from 4aabd2d to e45f94e Compare July 15, 2022 22:21
@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #103 (d2996aa) into develop (6389192) will decrease coverage by 0.25467%.
The diff coverage is 86.56716%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #103         +/-   ##
===================================================
- Coverage   93.64053%   93.38586%   -0.25468%     
===================================================
  Files            222         233         +11     
  Lines          13303       13834        +531     
  Branches         704         746         +42     
===================================================
+ Hits           12457       12919        +462     
- Misses           613         674         +61     
- Partials         233         241          +8     
Flag Coverage Δ
unittests 93.38586% <86.56716%> (-0.25468%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...InformaticsGateway/Services/Common/ITcpListener.cs 0.00000% <0.00000%> (ø)
...ticsGateway/Services/Common/ITcpListenerFactory.cs 0.00000% <0.00000%> (ø)
...icsGateway/Services/Common/NetworkStreamAdapter.cs 0.00000% <0.00000%> (ø)
...rmaticsGateway/Services/Common/TcpClientAdapter.cs 0.00000% <0.00000%> (ø)
...ateway/Services/HealthLevel7/IMllpClientFactory.cs 0.00000% <0.00000%> (ø)
...csGateway/Services/Http/DicomWeb/StowController.cs 84.61538% <ø> (ø)
src/InformaticsGateway/Services/Scp/ScpService.cs 76.92308% <0.00000%> (ø)
.../Test/Services/Export/DicomWebExportServiceTest.cs 100.00000% <ø> (ø)
...maticsGateway/Services/HealthLevel7/MllpService.cs 78.12500% <78.12500%> (ø)
...rmaticsGateway/Services/HealthLevel7/MllpClient.cs 79.77528% <79.77528%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6389192...d2996aa. Read the comment docs.

Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
@mocsharp mocsharp merged commit 2345730 into develop Aug 4, 2022
@mocsharp mocsharp deleted the vchang/hl7v2 branch August 4, 2022 21:46
@mocsharp mocsharp modified the milestones: 0.3.0, 0.2.0 Aug 16, 2022
mocsharp added a commit that referenced this pull request Aug 19, 2022
* gh-8 initial implementation of HL7 MLLP Frame listener
* gh-8 Update integration test

Signed-off-by: Victor Chang <[email protected]>
@github-actions
Copy link

🎉 This issue has been resolved in version 0.2.0 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature
Projects
Development

Successfully merging this pull request may close these issues.

Simple HL7 Interface for orders
2 participants