Add GH Action to check file headers #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #106 +/- ##
===================================================
+ Coverage 93.64375% 93.65879% +0.01503%
===================================================
Files 222 222
Lines 13294 13294
Branches 702 702
===================================================
+ Hits 12449 12451 +2
+ Misses 612 611 -1
+ Partials 233 232 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| @@ -99,6 +116,12 @@ jobs: | |||
|
|
|||
| - name: Secret detection | |||
| uses: gitleaks/[email protected] | |||
|
|
|||
| - name: Perform License Scanning | |||
| run: license_finder -r | |||
There was a problem hiding this comment.
Does this need the allowlist adding? Also does it need a mention in the README how it can be added to?
There was a problem hiding this comment.
Good call! I have updated CONTRIBUTING.md with information on license/package scanning!
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
RemakingEden
approved these changes
Jul 21, 2022
mocsharp
added a commit
that referenced
this pull request
Aug 19, 2022
* Enable license finder & header scan * Update files with full Apache-2.0 text * Update CONTRIBUTING with license/package scanning info Signed-off-by: Victor Chang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checks files for a valid Apache-2.0 header otherwise fail the build.
This change requires changing existing SPDX license headers to include full Apache-2.0 license text.
Adds nuget license scanning
Status
Ready
Types of changes