Skip to content

Queue logic updates #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 4, 2022
Merged

Queue logic updates #107

merged 3 commits into from
Aug 4, 2022

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Jul 25, 2022

Description

  • Re-queue export request instead of reject when disk space is low.
  • Subscribe with queue names

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@mocsharp mocsharp added the bug Something isn't working label Jul 25, 2022
@mocsharp mocsharp added this to the 0.2.0 milestone Jul 25, 2022
@mocsharp mocsharp requested a review from jackschofield23 July 25, 2022 20:00
@mocsharp mocsharp self-assigned this Jul 25, 2022
@mocsharp mocsharp modified the milestones: 0.2.0, 0.3.0 Jul 26, 2022
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #107 (5cfc06b) into develop (d05f1e3) will decrease coverage by 0.02208%.
The diff coverage is 96.96970%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #107         +/-   ##
===================================================
- Coverage   93.63302%   93.61094%   -0.02209%     
===================================================
  Files            222         222                 
  Lines          13303       13304          +1     
  Branches         703         703                 
===================================================
- Hits           12456       12454          -2     
- Misses           615         617          +2     
- Partials         232         233          +1     
Flag Coverage Δ
unittests 93.61094% <96.96970%> (-0.02209%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/InformaticsGateway/Test/DummyMessagingService.cs 37.50000% <0.00000%> (-2.50000%) ⬇️
...maticsGateway/Services/Export/ExportServiceBase.cs 86.45161% <100.00000%> (ø)
.../Test/Services/Export/DicomWebExportServiceTest.cs 100.00000% <100.00000%> (ø)
...eway/Test/Services/Export/ExportServiceBaseTest.cs 98.05195% <100.00000%> (ø)
...teway/Test/Services/Export/ScuExportServiceTest.cs 99.73262% <100.00000%> (ø)
...Test/Services/Storage/SpaceReclaimerServiceTest.cs 94.79167% <0.00000%> (-2.08334%) ⬇️
...ateway/Services/Connectors/DataRetrievalService.cs 83.69906% <0.00000%> (-0.62696%) ⬇️
...sGateway/Services/Storage/SpaceReclaimerService.cs 75.60976% <0.00000%> (+2.43902%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d05f1e3...5cfc06b. Read the comment docs.

mocsharp and others added 3 commits August 4, 2022 08:36
@mocsharp mocsharp merged commit 9cf7320 into develop Aug 4, 2022
@mocsharp mocsharp deleted the vchang/requeue branch August 4, 2022 15:57
@mocsharp mocsharp modified the milestones: 0.3.0, 0.2.0 Aug 16, 2022
mocsharp added a commit that referenced this pull request Aug 19, 2022
- Re-queue export request instead of reject when disk space is low.
- Subscribe with queue names

Signed-off-by: Victor Chang <[email protected]>
@github-actions
Copy link

🎉 This issue has been resolved in version 0.2.0 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

2 participants