fixing up docker issues from dev environment #109
Conversation
Signed-off-by: Neil South <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #109 +/- ##
===================================================
+ Coverage 93.62118% 93.64423% +0.02304%
===================================================
Files 222 222
Lines 13294 13295 +1
Branches 702 702
===================================================
+ Hits 12446 12450 +4
+ Misses 615 612 -3
Partials 233 233
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| @@ -3,7 +3,7 @@ | |||
| "Monai.Deploy.InformaticsGateway": { | |||
| "commandName": "Project", | |||
| "environmentVariables": { | |||
| "DOTNET_ENVIRONMENT": "Development" | |||
| "DOTNET_ENVIRONMENT": "Local" | |||
There was a problem hiding this comment.
Any difference between using Local vs Development?
There was a problem hiding this comment.
Just in MWM tests were/are using appsetting.development.json to read settings from (bad Idea!) so making a copy of it and using that for local development only was my solution (as my machine has services running on different ports)
happy to revert this file, if you think thats best
|
Please do not merge until #98 is merged & release/0.2.0 branch is created. |
| @@ -47,6 +47,8 @@ COPY --from=build /tools /opt/dotnetcore-tools | |||
| EXPOSE 104 | |||
| EXPOSE 5000 | |||
|
|
|||
| RUN mkdir /database/ | |||
There was a problem hiding this comment.
This is mapped into the container, and that's why we don't create it in the Dockefile.
There was a problem hiding this comment.
Right ok, so this should be a volume mount point then.
There was a problem hiding this comment.
Right, it's a mount point. Can we remove this so that it doesn't become a silent failure?
|
Not needed |
Signed-off-by: Neil South [email protected]
Description
Fixes # .
A few issues including adding in plug-in's and also a /database/ folder to the docker image
Status
Ready
Types of changes